Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 11366084: Android: disable use of libyuv. (Closed)

Created:
8 years, 1 month ago by Torne
Modified:
8 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Android: disable use of libyuv. The Anrdoid WebView build doesn't have libyuv, so the code depending on it was broken there. It doesn't look like we need this on Android at all, so just disable it based on OS for now; this can be revisited if it's needed later. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=166190

Patch Set 1 #

Total comments: 2

Patch Set 2 : Tidy up ifdef for header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M content/browser/renderer_host/media/video_capture_controller.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M content/content_browser.gypi View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Torne
8 years, 1 month ago (2012-11-05 12:16:38 UTC) #1
mflodman_chromium_OOO
LGTM with one comment. https://codereview.chromium.org/11366084/diff/1/content/browser/renderer_host/media/video_capture_controller.cc File content/browser/renderer_host/media/video_capture_controller.cc (right): https://codereview.chromium.org/11366084/diff/1/content/browser/renderer_host/media/video_capture_controller.cc#newcode17 content/browser/renderer_host/media/video_capture_controller.cc:17: #if !defined(OS_ANDROID) Can you please ...
8 years, 1 month ago (2012-11-05 12:31:46 UTC) #2
Torne
https://codereview.chromium.org/11366084/diff/1/content/browser/renderer_host/media/video_capture_controller.cc File content/browser/renderer_host/media/video_capture_controller.cc (right): https://codereview.chromium.org/11366084/diff/1/content/browser/renderer_host/media/video_capture_controller.cc#newcode17 content/browser/renderer_host/media/video_capture_controller.cc:17: #if !defined(OS_ANDROID) On 2012/11/05 12:31:46, mflodman wrote: > Can ...
8 years, 1 month ago (2012-11-05 12:41:09 UTC) #3
Torne
+xians for OWNERS in content/browser/renderer_host/media
8 years, 1 month ago (2012-11-05 12:44:40 UTC) #4
no longer working on chromium
On 2012/11/05 12:44:40, Torne wrote: > +xians for OWNERS in content/browser/renderer_host/media owner stamp lgtm
8 years, 1 month ago (2012-11-05 12:55:27 UTC) #5
Torne
+jam for content/ OWNERS
8 years, 1 month ago (2012-11-05 14:07:57 UTC) #6
jam
8 years, 1 month ago (2012-11-05 18:27:02 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698