runtime/vm/stub_code_ia32.cc - Issue 11366076: Remove special meaning when usage counter reaches the threshold.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stub_code_ia32.cc

Issue 11366076: Remove special meaning when usage counter reaches the threshold. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/stub_code_ia32.cc

===================================================================

--- runtime/vm/stub_code_ia32.cc (revision 14538)

+++ runtime/vm/stub_code_ia32.cc (working copy)

@@ -1554,11 +1554,7 @@

// The usage_counter is always less than FLAG_optimization_counter_threshold

// except when the function gets optimized.

__ cmpl(FieldAddress(temp_reg, Function::usage_counter_offset()),

- Immediate(FLAG_optimization_counter_threshold - 1));

- // Do not increment to equality with threshold, since a counter greater

- // than threshold denotes a function that was already optimized.

- // The equality should be reached only at exit of the method

- // (return instruction).

+ Immediate(FLAG_optimization_counter_threshold));

__ j(EQUAL, &is_hot, Assembler::kNearJump);

// As long as VM has no OSR do not optimize in the middle of the function

// but only at exit so that we have collected all type feedback before

« no previous file with comments | « runtime/vm/intermediate_language_x64.cc ('k') | runtime/vm/stub_code_x64.cc » ('j') | no next file with comments »