Issue 11366075: Merge 165468 - Fix a crash that could occur if the user closed a tab with an uncommitted search nav…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11366075: Merge 165468 - Fix a crash that could occur if the user closed a tab with an uncommitted search nav… (Closed)

Created:
8 years, 1 month ago by Peter Kasting

Modified:
8 years, 1 month ago

Reviewers:
Peter Kasting

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/branches/1312/src/

Visibility:
Public.

More Reviews

Description

Merge 165468 - Fix a crash that could occur if the user closed a tab with an uncommitted search navigation that we were planning to show a GoogleURLTracker infobar for. In this case the WebContents being destroyed does not necessarily have a valid InfoBarTabHelper anymore. This also fixes names and comments relating to the EntryMap (nee InfoBarMap) that probably should have been changed when I added GoogleURLTrackerMapEntry. BUG=158201 TEST=none Review URL: https://codereview.chromium.org/11339060 TBR=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165801

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+124 lines, -103 lines)			Patch
M	chrome/browser/google/google_url_tracker.h	View	3 chunks	+17 lines, -13 lines	0 comments	Download
M	chrome/browser/google/google_url_tracker.cc	View	14 chunks	+88 lines, -73 lines	0 comments	Download
M	chrome/browser/google/google_url_tracker_map_entry.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/google/google_url_tracker_unittest.cc	View	5 chunks	+14 lines, -15 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages