Take screenshots using /system/bin/screencap instead of monkeyrunner.

Add TakeScreenshot command to android_commands.

Also, take screenshots using /system/bin/screencap instead of monkeyrunner.


BUG=158851
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=166273

[klundberg, 2012-11-02 21:51:32]

lgtm

[Isaac (away), 2012-11-05 00:42:22]

Can you provide more context here?  What advantages does this have over
monkeyrunner?

Will it work on ICS?  What about unrooted phones?

[frankf, 2012-11-05 18:30:59]

Using monkeyrunner just for screenshots is an overkill and an extra host-side
dep. I've checked this works on non-rooted/ICS as well.

On 2012/11/05 00:42:22, Isaac wrote:
> Can you provide more context here?  What advantages does this have over
> monkeyrunner?
> 
> Will it work on ICS?  What about unrooted phones?

[frankf, 2012-11-05 23:21:21]

Marcus, can you take a look please?

[bulach, 2012-11-06 11:06:48]

lgtm, I agree if it works everywhere, having less dependencies is better.

one suggestion below:

http://codereview.chromium.org/11366068/diff/1/build/android/pylib/run_java_t...
File build/android/pylib/run_java_tests.py (right):

http://codereview.chromium.org/11366068/diff/1/build/android/pylib/run_java_t...
build/android/pylib/run_java_tests.py:245: os.mkdir(constants.SCREENSHOTS_DIR)
nit: maybe move 244-245 this to TakeScreenshot using
os.path.basename(screenshot_name) there?

[frankf, 2012-11-06 19:04:40]

http://codereview.chromium.org/11366068/diff/1/build/android/pylib/run_java_t...
File build/android/pylib/run_java_tests.py (right):

http://codereview.chromium.org/11366068/diff/1/build/android/pylib/run_java_t...
build/android/pylib/run_java_tests.py:245: os.mkdir(constants.SCREENSHOTS_DIR)
Hmm. I think it's more flexible for the caller to decide where to save the
screenshot.

[bulach, 2012-11-06 19:06:06]

http://codereview.chromium.org/11366068/diff/1/build/android/pylib/run_java_t...
File build/android/pylib/run_java_tests.py (right):

http://codereview.chromium.org/11366068/diff/1/build/android/pylib/run_java_t...
build/android/pylib/run_java_tests.py:245: os.mkdir(constants.SCREENSHOTS_DIR)
On 2012/11/06 19:04:40, frankf wrote:
> Hmm. I think it's more flexible for the caller to decide where to save the
> screenshot.

sorry, my suggestion was just to move the check and mkdir to TakeScreenshot
rather than here, but yes, keep the actual dir  choice in the caller...

[frankf, 2012-11-06 19:44:03]

https://codereview.chromium.org/11366068/diff/1/build/android/pylib/run_java_...
File build/android/pylib/run_java_tests.py (right):

https://codereview.chromium.org/11366068/diff/1/build/android/pylib/run_java_...
build/android/pylib/run_java_tests.py:245: os.mkdir(constants.SCREENSHOTS_DIR)
Ah. Done.

On 2012/11/06 19:06:06, bulach wrote:
> On 2012/11/06 19:04:40, frankf wrote:
> > Hmm. I think it's more flexible for the caller to decide where to save the
> > screenshot.
> 
> sorry, my suggestion was just to move the check and mkdir to TakeScreenshot
> rather than here, but yes, keep the actual dir  choice in the caller...

[bulach, 2012-11-07 10:10:34]

lgtm, thanks!