chrome/browser/chromeos/web_socket_proxy.cc - Issue 11366060: Clang: enable -Wtautological-constant-out-of-range-compare

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/web_socket_proxy.cc

Issue 11366060: Clang: enable -Wtautological-constant-out-of-range-compare (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address thakis's comments Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/web_socket_proxy.cc

diff --git a/chrome/browser/chromeos/web_socket_proxy.cc b/chrome/browser/chromeos/web_socket_proxy.cc

index 0eecd1d885893e7b1a3d6626880ec6de004aadb0..425f25f8b963d58621d851d9cc22ffe123547a12 100644

--- a/chrome/browser/chromeos/web_socket_proxy.cc

+++ b/chrome/browser/chromeos/web_socket_proxy.cc

@@ -1310,7 +1310,7 @@ bool Conn::EmitFrame(

uint8 header[10];

int header_size = 2;

DCHECK(chan);

- DCHECK(opcode >= 0 && opcode < 16);

+ DCHECK(opcode >= 0 && static_cast<int>(opcode) < 16);

header[0] = opcode | 0x80; // FIN bit set.

if (size < 126) {

header[1] = size;

« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »