Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 11366044: ninja: Don't assume that depot_tools is in PATH. (Closed)

Created:
8 years, 1 month ago by Nico
Modified:
8 years, 1 month ago
Reviewers:
nsylvain, scottmg
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel
Visibility:
Public.

Description

ninja: Don't assume that depot_tools is in PATH. TEST=`~/src/depot_tools/ninja --version` works when depot_tools isn't in PATH Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165510

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M ninja View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
8 years, 1 month ago (2012-11-01 21:38:46 UTC) #1
scottmg
lgtm
8 years, 1 month ago (2012-11-01 21:42:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/11366044/1
8 years, 1 month ago (2012-11-01 21:43:56 UTC) #3
commit-bot: I haz the power
Presubmit check for 11366044-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 1 month ago (2012-11-01 21:46:06 UTC) #4
nsylvain
lgtm
8 years, 1 month ago (2012-11-01 21:47:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/11366044/1
8 years, 1 month ago (2012-11-01 21:48:19 UTC) #6
commit-bot: I haz the power
8 years, 1 month ago (2012-11-01 21:50:27 UTC) #7
Change committed as 165510

Powered by Google App Engine
This is Rietveld 408576698