Issue 11366011: [VS Addin] Update unit test result parser to handle inclusive results

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11366011: [VS Addin] Update unit test result parser to handle inclusive results (Closed)

Created:
8 years, 1 month ago by Sam Clegg

Modified:
8 years, 1 month ago

Reviewers:
binji

CC:
native-client-reviews_googlegroups.com

Base URL:
http://nativeclient-sdk.googlecode.com/svn/trunk/src

Visibility:
Public.

More Reviews

Description

[VS Addin] Test result parser now handles inconclusive results. Inconclusive results are the MS unit tests way of signalling that a test was skipped. We don't want to treat these tests as failures on the bots. This change also cleans up the output of check_test_results. BUG= Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1461

Patch Set 1 #

Total comments: 1

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -6 lines)			Patch
	M	visual_studio/NativeClientVSAddIn/check_test_results.py	View		1 chunk	+9 lines, -6 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

binji

8 years, 1 month ago (2012-10-31 19:15:00 UTC) #3

lgtm

http://codereview.chromium.org/11366011/diff/1/visual_studio/NativeClientVSAd...
File visual_studio/NativeClientVSAddIn/check_test_results.py (right):

http://codereview.chromium.org/11366011/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/check_test_results.py:35: #print test_run_name
remove commented code

Expand Messages | Collapse Messages