Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Side by Side Diff: content/renderer/render_frame_impl.cc

Issue 1136593003: Delete entry in WebFrame->RenderFrameProxy map at WebFrame::close time. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a comment for the frameDetached call. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/renderer/render_frame_proxy.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_frame_impl.h" 5 #include "content/renderer/render_frame_impl.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 9
10 #include "base/auto_reset.h" 10 #include "base/auto_reset.h"
(...skipping 712 matching lines...) Expand 10 before | Expand all | Expand 10 after
723 723
724 RenderFrameImpl::~RenderFrameImpl() { 724 RenderFrameImpl::~RenderFrameImpl() {
725 FOR_EACH_OBSERVER(RenderFrameObserver, observers_, RenderFrameGone()); 725 FOR_EACH_OBSERVER(RenderFrameObserver, observers_, RenderFrameGone());
726 FOR_EACH_OBSERVER(RenderFrameObserver, observers_, OnDestruct()); 726 FOR_EACH_OBSERVER(RenderFrameObserver, observers_, OnDestruct());
727 727
728 #if defined(VIDEO_HOLE) 728 #if defined(VIDEO_HOLE)
729 if (contains_media_player_) 729 if (contains_media_player_)
730 render_view_->UnregisterVideoHoleFrame(this); 730 render_view_->UnregisterVideoHoleFrame(this);
731 #endif 731 #endif
732 732
733 if (render_frame_proxy_) 733 // RenderFrameProxy is only "owned" by RenderFrameImpl in the case it is the
734 delete render_frame_proxy_; 734 // main frame. Ensure it is deleted along with this object.
735 if (!is_subframe_ && render_frame_proxy_) {
736 // The following method calls back into this object and clears
737 // |render_frame_proxy_|.
738 render_frame_proxy_->frameDetached();
739 }
735 740
736 render_view_->UnregisterRenderFrame(this); 741 render_view_->UnregisterRenderFrame(this);
737 g_routing_id_frame_map.Get().erase(routing_id_); 742 g_routing_id_frame_map.Get().erase(routing_id_);
738 RenderThread::Get()->RemoveRoute(routing_id_); 743 RenderThread::Get()->RemoveRoute(routing_id_);
739 } 744 }
740 745
741 void RenderFrameImpl::SetWebFrame(blink::WebLocalFrame* web_frame) { 746 void RenderFrameImpl::SetWebFrame(blink::WebLocalFrame* web_frame) {
742 DCHECK(!frame_); 747 DCHECK(!frame_);
743 748
744 std::pair<FrameMap::iterator, bool> result = g_frame_map.Get().insert( 749 std::pair<FrameMap::iterator, bool> result = g_frame_map.Get().insert(
(...skipping 4187 matching lines...) Expand 10 before | Expand all | Expand 10 after
4932 #elif defined(ENABLE_BROWSER_CDMS) 4937 #elif defined(ENABLE_BROWSER_CDMS)
4933 cdm_manager_, 4938 cdm_manager_,
4934 #endif 4939 #endif
4935 this); 4940 this);
4936 } 4941 }
4937 4942
4938 return cdm_factory_; 4943 return cdm_factory_;
4939 } 4944 }
4940 4945
4941 } // namespace content 4946 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | content/renderer/render_frame_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698