Use the Errorprone Compiler

build/java_apk.gypi

Index: build/java_apk.gypi
diff --git a/build/java_apk.gypi b/build/java_apk.gypi
index 2af3a8a83fda67430e21d85e9857f6492e8f055f..fb4efd9246dfc329635f2db08c0cbcfbe2e7c874 100644
--- a/build/java_apk.gypi
+++ b/build/java_apk.gypi
@@ -180,6 +180,11 @@
     'extra_native_libs': [],
     'native_lib_placeholder_stamp': '<(apk_package_native_libs_dir)/<(android_app_abi)/native_lib_placeholder.stamp',
     'native_lib_placeholders': [],
+    'enable_errorprone%': '1',
+

[jbudorick, 2015/05/15 18:37:13]

No need for line breaks.

[raywilliams_chromium, 2015/05/18 19:53:24]

Done.

+
+
+    'errorprone_exe_path': '<(PRODUCT_DIR)/bin.java/chromium_errorprone',
   },
   # Pass the jar path to the apk's "fake" jar target.  This would be better as
   # direct_dependent_settings, but a variable set by a direct_dependent_settings
@@ -222,6 +227,16 @@
         '<(DEPTH)/base/base.gyp:chromium_android_linker',
       ],
     }],
+

[jbudorick, 2015/05/15 18:37:12]

same

[raywilliams_chromium, 2015/05/18 19:53:24]

Done.

+
+    ['enable_errorprone == 1', {
+      'dependencies': [
+        '<(DEPTH)/third_party/errorprone/errorprone.gyp:chromium_errorprone',
+      ],
+    }],
+
+
+
     ['native_lib_target != ""', {
       'variables': {
         'conditions': [
@@ -668,7 +683,17 @@
         # targets use the same java_in_dir and both use java_apk.gypi or
         # both use java.gypi.)
         'java_sources': ['>!@(find >(java_in_dir)>(java_in_dir_suffix) >(additional_src_dirs) -name "*.java"  # apk)'],
-
+        'conditions': [
+          ['enable_errorprone == 0', {
+            'extra_inputs': [
+              '<(errorprone_exe_path)',
+            ],
+            'extra_args': [ '--errorprone-path=<(errorprone_exe_path)' ],

[jbudorick, 2015/05/15 18:37:12]

same args comment, although this one is flipped somewhat -- the other
enable_errorprone was == 1, this one is == 0

[raywilliams_chromium, 2015/05/18 19:53:24]

Done.

+          }, {
+            'extra_inputs': [],
+            'extra_args': [ '--enable-errorprone' ],
+          }],
+        ],
       },
       'inputs': [
         '<(DEPTH)/build/android/gyp/util/build_utils.py',
@@ -676,6 +701,7 @@
         '>@(java_sources)',
         '>@(input_jars_paths)',
         '<(codegen_stamp)',
+        '<@(extra_inputs)',
       ],
       'conditions': [
         ['native_lib_target != ""', {
@@ -695,6 +721,7 @@
         '--jar-path=<(javac_jar_path)',
         '--jar-excluded-classes=<(jar_excluded_classes)',
         '--stamp=<(compile_stamp)',
+        '<@(extra_args)',
         '>@(java_sources)',
       ],
     },