Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1664)

Unified Diff: build/config/android/rules.gni

Issue 1136573002: Use the Errorprone Compiler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use public jar instead of local Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/android/rules.gni
diff --git a/build/config/android/rules.gni b/build/config/android/rules.gni
index 67d2b5d9923ba383248b7a3cf972d67699ff78d4..7d4f21513c39e15a9f40d9b66272929705694f9c 100644
--- a/build/config/android/rules.gni
+++ b/build/config/android/rules.gni
@@ -746,7 +746,7 @@ template("java_strings_grd_prebuilt") {
build_config = base_path + ".build_config"
build_config_target_name = "${target_name}__build_config"
- zip_target_name ="${target_name}__zip"
+ zip_target_name = "${target_name}__zip"
final_target_name = target_name
write_build_config(build_config_target_name) {
@@ -798,6 +798,7 @@ template("java_strings_grd_prebuilt") {
# android_library target, for example.
#
# chromium_code: If true, extra analysis warning/errors will be enabled.
+# enable_errorprone: If true, enables the errorprone compiler.
#
# data_deps, testonly
#
@@ -825,6 +826,9 @@ template("java_binary") {
if (defined(invoker.deps)) {
deps = invoker.deps
}
+ if (defined(invoker.enable_errorprone)) {
+ enable_errorprone = invoker.enable_errorprone
+ }
if (defined(invoker.java_files)) {
java_files = invoker.java_files
}
@@ -919,6 +923,8 @@ template("junit_binary") {
# ease the gyp->gn conversion and will be removed in the future.
#
# chromium_code: If true, extra analysis warning/errors will be enabled.
+# enable_errorprone: If true, enables the errorprone compiler.
+#
# jar_excluded_patterns: List of patterns of .class files to exclude from the
# final jar.
#
@@ -967,6 +973,9 @@ template("java_library") {
if (defined(invoker.deps)) {
deps = invoker.deps
}
+ if (defined(invoker.enable_errorprone)) {
+ enable_errorprone = invoker.enable_errorprone
+ }
if (defined(invoker.jar_excluded_patterns)) {
jar_excluded_patterns = invoker.jar_excluded_patterns
}
@@ -1058,6 +1067,8 @@ template("java_prebuilt") {
# ease the gyp->gn conversion and will be removed in the future.
#
# chromium_code: If true, extra analysis warning/errors will be enabled.
+# enable_errorprone: If true, enables the errorprone compiler.
+#
# jar_excluded_patterns: List of patterns of .class files to exclude from the
# final jar.
#
@@ -1103,6 +1114,9 @@ template("android_library") {
if (defined(invoker.deps)) {
deps = invoker.deps
}
+ if (defined(invoker.enable_errorprone)) {
+ enable_errorprone = invoker.enable_errorprone
+ }
if (defined(invoker.jar_excluded_patterns)) {
jar_excluded_patterns = invoker.jar_excluded_patterns
}

Powered by Google App Engine
This is Rietveld 408576698