Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: build/config/android/internal_rules.gni

Issue 1136573002: Use the Errorprone Compiler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Extracted some constants Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 6
7 assert(is_android) 7 assert(is_android)
8 8
9 rebased_android_sdk = rebase_path(android_sdk, root_build_dir) 9 rebased_android_sdk = rebase_path(android_sdk, root_build_dir)
10 rebased_android_sdk_root = rebase_path(android_sdk_root, root_build_dir) 10 rebased_android_sdk_root = rebase_path(android_sdk_root, root_build_dir)
(...skipping 731 matching lines...) Expand 10 before | Expand all | Expand 10 after
742 742
743 _jar_excluded_patterns = [] 743 _jar_excluded_patterns = []
744 if (defined(invoker.jar_excluded_patterns)) { 744 if (defined(invoker.jar_excluded_patterns)) {
745 _jar_excluded_patterns += invoker.jar_excluded_patterns 745 _jar_excluded_patterns += invoker.jar_excluded_patterns
746 } 746 }
747 747
748 _chromium_code = false 748 _chromium_code = false
749 if (defined(invoker.chromium_code)) { 749 if (defined(invoker.chromium_code)) {
750 _chromium_code = invoker.chromium_code 750 _chromium_code = invoker.chromium_code
751 } 751 }
752
753 _enable_errorprone = false
754 if (defined(invoker.enable_errorprone)) {
755 _enable_errorprone = invoker.enable_errorprone
756 }
757
752 _manifest_entries = [] 758 _manifest_entries = []
753 if (defined(invoker.manifest_entries)) { 759 if (defined(invoker.manifest_entries)) {
754 _manifest_entries = invoker.manifest_entries 760 _manifest_entries = invoker.manifest_entries
755 } 761 }
756 762
757 _srcjar_deps = [] 763 _srcjar_deps = []
758 if (defined(invoker.srcjar_deps)) { 764 if (defined(invoker.srcjar_deps)) {
759 _srcjar_deps += invoker.srcjar_deps 765 _srcjar_deps += invoker.srcjar_deps
760 } 766 }
761 767
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
805 "--java-srcjars=$_rebased_java_srcjars", 811 "--java-srcjars=$_rebased_java_srcjars",
806 "--java-srcjars=@FileArg($_rebased_build_config:javac:srcjars)", 812 "--java-srcjars=@FileArg($_rebased_build_config:javac:srcjars)",
807 "--jar-excluded-classes=$_jar_excluded_patterns", 813 "--jar-excluded-classes=$_jar_excluded_patterns",
808 ] 814 ]
809 foreach(e, _manifest_entries) { 815 foreach(e, _manifest_entries) {
810 args += [ "--manifest-entry=" + e ] 816 args += [ "--manifest-entry=" + e ]
811 } 817 }
812 if (_chromium_code) { 818 if (_chromium_code) {
813 args += [ "--chromium-code=1" ] 819 args += [ "--chromium-code=1" ]
814 } 820 }
815 821 if (_enable_errorprone) {
822 args += [ "--enable-errorprone" ]
cjhopman 2015/05/20 02:21:29 This condition shouldn't add anything to args
raywilliams_chromium 2015/05/20 21:31:55 Done.
823 } else {
824 deps += [ "//third_party/errorprone:chromium_errorprone" ]
825 args += [
826 "--errorprone-path",
827 "bin/chromium_errorprone",
828 ]
829 }
816 args += rebase_path(_java_files, root_build_dir) 830 args += rebase_path(_java_files, root_build_dir)
817 } 831 }
818 832
819 _final_deps += [ ":${_template_name}__finish" ] 833 _final_deps += [ ":${_template_name}__finish" ]
820 process_java_prebuilt("${_template_name}__finish") { 834 process_java_prebuilt("${_template_name}__finish") {
821 build_config = _build_config 835 build_config = _build_config
822 input_jar_path = _intermediate_jar_path 836 input_jar_path = _intermediate_jar_path
823 output_jar_path = _final_jar_path 837 output_jar_path = _final_jar_path
824 if (defined(invoker.proguard_preprocess) && invoker.proguard_preprocess) { 838 if (defined(invoker.proguard_preprocess) && invoker.proguard_preprocess) {
825 proguard_preprocess = invoker.proguard_preprocess 839 proguard_preprocess = invoker.proguard_preprocess
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
933 _final_deps += [ ":${_template_name}__compile_java" ] 947 _final_deps += [ ":${_template_name}__compile_java" ]
934 compile_java("${_template_name}__compile_java") { 948 compile_java("${_template_name}__compile_java") {
935 jar_path = _jar_path 949 jar_path = _jar_path
936 build_config = _build_config 950 build_config = _build_config
937 java_files = _java_files 951 java_files = _java_files
938 srcjar_deps = _srcjar_deps 952 srcjar_deps = _srcjar_deps
939 srcjars = _srcjars 953 srcjars = _srcjars
940 chromium_code = _chromium_code 954 chromium_code = _chromium_code
941 android = _requires_android 955 android = _requires_android
942 956
957 if (defined(invoker.enable_errorprone)) {
958 enable_errorprone = invoker.enable_errorprone
959 }
943 if (defined(invoker.jar_excluded_patterns)) { 960 if (defined(invoker.jar_excluded_patterns)) {
944 jar_excluded_patterns = invoker.jar_excluded_patterns 961 jar_excluded_patterns = invoker.jar_excluded_patterns
945 } 962 }
946 if (defined(invoker.proguard_preprocess)) { 963 if (defined(invoker.proguard_preprocess)) {
947 proguard_preprocess = invoker.proguard_preprocess 964 proguard_preprocess = invoker.proguard_preprocess
948 } 965 }
949 if (defined(invoker.proguard_config)) { 966 if (defined(invoker.proguard_config)) {
950 proguard_config = invoker.proguard_config 967 proguard_config = invoker.proguard_config
951 } 968 }
952 if (defined(invoker.dist_jar_path)) { 969 if (defined(invoker.dist_jar_path)) {
(...skipping 295 matching lines...) Expand 10 before | Expand all | Expand 10 after
1248 script = "//build/android/gyp/generate_split_manifest.py" 1265 script = "//build/android/gyp/generate_split_manifest.py"
1249 outputs = [ 1266 outputs = [
1250 depfile, 1267 depfile,
1251 invoker.out_manifest, 1268 invoker.out_manifest,
1252 ] 1269 ]
1253 inputs = [ 1270 inputs = [
1254 invoker.main_manifest, 1271 invoker.main_manifest,
1255 ] 1272 ]
1256 } 1273 }
1257 } 1274 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698