Use the Errorprone Compiler

BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This is the root build file for GN. GN will start processing by loading this
 # file, and recursively load all dependencies until all dependencies are either
 # resolved or known not to exist (which will cause the build to fail). So if
 # you add a new build file, there must be some path of dependencies from this
 # file to your new one or GN won't know about it.
 
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//build/module_args/v8.gni")
 
 if (is_android) {
   import("//build/config/android/config.gni")
 }
 
 declare_args() {
   # A list of extra dependencies to add to the root target. This allows a
   # checkout to add additional targets without explicitly changing any checked-
   # in files.
   root_extra_deps = []
 }
 
-# This file defines the following four main targets:
+# This file defines the following three main targets:
 #
 # "both_gn_and_gyp" should list every root target (target that nothing else
 # depends on) built by GN that is also built in the GYP build.
 #
 # "gn_all" should (transitively) cause everything to be built; if you run
 # 'ninja gn_all' and then 'ninja all', the second build should do no work.
 #
 # "gn_only" should list every root target that is *not* intended to be built
 # in a GYP build. Because GN has different rules for deciding what an 'all'
 # build is, this may end up including targets that are actually defined in a
 # GYP build but not dependencies of GYP's "all" (and so not actually built).
 #
-# "gn_visibility": targets that are normally not visible to top-level targets,
-# but are built anyway by "all". Since we don't want any such targets, we
-# have this placeholder to make sure hidden targets that aren't otherwise
-# depended on yet are accounted for.
-#
 # TODO(GYP): crbug.com/481694. Make sure that the above is true and there are
 # scripts run on the bots that enforce this. Once the GYP migration is over,
 # we can collapse all of these targets as desired.
 
 group("gn_all") {
   testonly = true
 
   deps = [
     ":both_gn_and_gyp",
     ":gn_only",
-    ":gn_visibility",
   ]
 }
 
 # The "both_gn_and_gyp" target should reflect every target that is built
 # in both the GN and GYP builds, and ideally it should match the
 # "both_gn_and_gyp" target in build/gn_migration.gypi line-for-line.
 #
 # TODO(GYP): Add build steps that check and enforce this on the bots.
 group("both_gn_and_gyp") {
   testonly = true
@@ skipping 80 matching lines @@
     "//tools/gn",
     "//tools/gn:gn_unittests",
     "//tools/gn:generate_test_gn_data",
     "//tools/telemetry:bitmaptools($host_toolchain)",
     "//ui/accessibility:accessibility_unittests",
     "//ui/app_list:app_list_unittests",
     "//ui/base:ui_base_unittests",
     "//ui/display:display_unittests",
     "//ui/events:events_unittests",
     "//ui/gfx:gfx_unittests",
-    "//ui/gl:gl_unittests",
     "//ui/touch_selection:ui_touch_selection_unittests",
     "//url:url_unittests",
   ]
 
   deps += root_extra_deps
 
   if (enable_extensions && !is_mac) {
     # TODO(GYP): Get this working on the mac?
     deps += [ "//extensions/shell:app_shell_unittests" ]
   }
@@ skipping 52 matching lines @@
       "//components/user_manager",
       "//components/wallpaper",
       "//content/shell/android:content_shell_apk",
 
       # TODO(GYP): Are these needed, or will they be pulled in automatically?
       "//third_party/android_tools:android_gcm_java",
       "//third_party/android_tools:uiautomator_java",
       "//third_party/android_tools:android_support_v13_java",
       "//third_party/android_tools:android_support_v7_appcompat_java",
       "//third_party/android_tools:android_support_v7_mediarouter_java",
+      "//third_party/errorprone:chromium_errorprone",

[jbudorick, 2015/05/07 18:49:26]

I'm not sure that this needs to be in here, and I am sure that none of the other
changes should be in here.

[raywilliams_chromium, 2015/05/11 19:52:24]

Done.

[raywilliams_chromium, 2015/05/11 19:52:24]

I'll try taking this out and see if it still works.
The other stuff was the result of a version control mistake, they were all fixed
in patch set 2.

       "//third_party/mesa",
       "//third_party/mockito:mockito_java",
       "//third_party/openmax_dl/dl",
       "//third_party/speex",
       "//ui/android:ui_java",
 
       # TODO(GYP): Are these needed?
       "//chrome/test:test_support_unit",
       "//third_party/smhasher:murmurhash3",
       "//ui/message_center:test_support",
@@ skipping 293 matching lines @@
     deps -= [
       "//chrome",  # TODO(GYP)
       "//chrome/test:browser_tests",  # TODO(GYP)
       "//chrome/test:interactive_ui_tests",  # TODO(GYP)
       "//chrome/test:sync_integration_tests",  # TODO(GYP)
       "//chrome/test:unit_tests",  # TODO(GYP)
       "//components:components_browsertests",  # TODO(GYP)
       "//components:components_unittests",  # TODO(GYP)
       "//content/test:content_browsertests",  # TODO(GYP)
       "//content/test:content_perftests",  # TODO(GYP)
+      "//content/test:content_unittests",  # TODO(GYP)
       "//extensions:extensions_browsertests",  # TODO(GYP)
       "//extensions:extensions_unittests",  # TODO(GYP)
       "//net:net_unittests",  # TODO(GYP)
       "//ui/app_list:app_list_unittests",  # TODO(GYP)
       "//ui/gfx:gfx_unittests",  # TODO(GYP)
     ]
   }
 
   if (is_win) {
     deps += [
@@ skipping 20 matching lines @@
     ]
   } else if (!is_android) {
     deps += [ "//breakpad:symupload" ]
   }
 }
 
 group("gn_only") {
   testonly = true
 
   deps = [
-    "//mandoline:all",
+    "//mandoline:mandoline_all",
   ]
 
   if (!is_android && !is_ios) {
     deps += [ "//components/proximity_auth:proximity_auth_unittests" ]
   }
 
   if (is_linux && !is_chromeos) {
     # TODO(GYP): Figure out if any of these should be in gn_all
     # and figure out how cross-platform they are
     deps += [
@@ skipping 93 matching lines @@
       "//content/public/common:mojo_bindings_python",
       "//content/common:mojo_bindings_python",
       "//content/test:web_ui_test_mojo_bindings_python",
       "//device/battery:mojo_bindings_python",
       "//device/vibration:mojo_bindings_python",
       "//ipc/mojo:ipc_mojo_perftests",
       "//ipc/mojo:client_channel_python",
       "//media/mojo/interfaces:interfaces_python",
       "//media/mojo/services:cdm_service",
       "//media/mojo:tests",
-      "//mojo:tests",
+      "//mojo/services:apptests",
+      "//mojo/services:tests",
       "//net/interfaces:interfaces_python",
       "//third_party/mojo/src/mojo/edk/js/test:js_integration_tests",
       "//third_party/mojo/src/mojo/edk/js/tests:js_to_cpp_bindings_python",
       "//third_party/mojo/src/mojo/public/python:packaged_application",
       "//third_party/mojo/src/mojo/public/python:packaged_bindings",
       "//third_party/mojo/src/mojo/public/cpp/application:test_support_standalone",
       "//third_party/mojo_services/src/accessibility/public/interfaces:interfaces_python",
     ]
   }
 }
 
 group("gn_visibility") {
   deps = [
-    "//build/config/sanitizers:options_sources",
-
+    # "//build/config/sanitizers:options_sources",
     # "//third_party/pdfium:pdfium_embeddertests",  # TODO(GYP): visibility?
     # "//third_party/pdfium:pdfium_unittests",  # TODO(GYP): visibility?
-
-    "//ui/resources:repack_ui_test_mac_locale_pack",
-
+    # "//ui/resources:repack_ui_test_mac_locale_pack",
     # "//v8:v8_snapshot",  # TODO(GYP): visibility?
     # "//v8:postmortem-metadata",  # TODO(GYP): visibility?
   ]
 }
 
 if (is_linux) {
   # This group corresponds to the list of tests run on the waterfall for
   # desktop Linux GYP builds from testing/buildbot/chromium.linux.json. It's
   # here to help track GYP -> GN conversion progress.
   group("linux_default_tests") {
@@ skipping 41 matching lines @@
       "//third_party/mojo/src/mojo/edk/test:mojo_public_system_unittests",  # PASSES 2/25/2015
       "//third_party/mojo/src/mojo/edk/test:mojo_public_utility_unittests",
       "//ui/accessibility:accessibility_unittests",  # PASSES 2/25/2015
       "//ui/app_list:app_list_unittests",  # PASSES 2/25/2015
       "//ui/aura:aura_unittests",  # PASSES 2/25/2015
       "//ui/base:ui_base_unittests",  # PASSES 4/17/2015
       "//ui/compositor:compositor_unittests",  # PASSES 2/25/2015
       "//ui/display:display_unittests",  # PASSES 2/25/2015
       "//ui/events:events_unittests",  # PASSES 2/25/2015
       "//ui/gfx:gfx_unittests",  # PASSES 2/25/2015
-      "//ui/gl:gl_unittests",
       "//ui/touch_selection:ui_touch_selection_unittests",  # PASSES 2/25/2015
       "//ui/views:views_unittests",  # PASSES (*) 2/25/2015
       "//ui/wm:wm_unittests",  # PASSES 2/25/2015
       "//url:url_unittests",  # PASSES 2/25/2015
 
       # Note:
       # (*) Fails but failures match GYP build at time of testing.
     ]
 
     if (enable_nacl) {
       deps += [ "//components/nacl:nacl_loader_unittests" ]  # PASSES 3/28/2015
     }
   }
 } else if (is_win) {
   group("windows_default_tests") {
     testonly = true
     deps = [
       "//ash:ash_unittests",  # FAILS 4/20/2015
       "//base:base_unittests",  # PASSES 4/20/2015
       "//cc:cc_unittests",  # PASSES 4/17/2015
       "//chrome_elf:chrome_elf_unittests",  # FAILS 4/20/2015
-      "//chrome/app_installer:app_installer_unittests",  # PASSES 4/24/2015
-      "//chrome/installer/util:installer_util_unittests",
+      "//chrome/app_installer:app_installer_unittests",
       "//chrome/test:browser_tests",
       "//chrome/test:interactive_ui_tests",
       "//chrome/test:sync_integration_tests",  # Note: need to turn off incremental linking for debug.
       "//chrome/test:unit_tests",
       "//chrome/test/chromedriver:chromedriver_unittests",  # PASSES 4/20/2015
-      "//components:components_browsertests",  # PASSES 4/24/2015
+      "//components:components_browsertests",
       "//components:components_unittests",  # PASSES 4/17/2015
       "//courgette:courgette_unittests",  # PASSES 4/20/2015
       "//content/test:content_browsertests",
       "//content/test:content_unittests",  # PASSES 4/17/2015
       "//crypto:crypto_unittests",  # PASSES 4/17/2015
       "//device:device_unittests",  # PASSES 4/17/2015
       "//extensions:extensions_browsertests",  # PASSES 4/17/2015
       "//extensions:extensions_unittests",  # PASSES 4/17/2015
       "//extensions/shell:app_shell_unittests",  # Doesn't compile in 64-bit
       "//google_apis/gcm:gcm_unit_tests",  # PASSES 4/17/2015
@@ skipping 22 matching lines @@
       "//third_party/mojo/src/mojo/edk/test:mojo_public_system_unittests",  # PASSES 4/20/2015
       "//third_party/mojo/src/mojo/edk/test:mojo_public_utility_unittests",  # PASSES 4/20/2015
       "//ui/accessibility:accessibility_unittests",  # PASSES 4/20/2015
       "//ui/app_list:app_list_unittests",  # PASSES 4/20/2015
       "//ui/aura:aura_unittests",  # PASSES 4/17/2015
       "//ui/base:ui_base_unittests",  # PASSES 4/20/2015
       "//ui/compositor:compositor_unittests",  # PASSES 4/20/2015
       "//ui/display:display_unittests",  # PASSES 4/20/2015
       "//ui/events:events_unittests",  # PASSES 4/20/2015
       "//ui/gfx:gfx_unittests",  # PASSES (with assertion failure?) 4/20/2015
-      "//ui/gl:gl_unittests",
       "//ui/message_center:message_center_unittests",  # PASSES 4/20/2015
       "//ui/touch_selection:ui_touch_selection_unittests",  # PASSES 4/20/2015
       "//ui/views:views_unittests",  # TooltipControllerTest failures
       "//ui/wm:wm_unittests",  # PASSES 4/21/2015
       "//url:url_unittests",  # PASSES 4/17/2015
 
+      # TODO(GYP) installer_util_unittests
+      # TODO(GYP) app_installer_unittests
       # TODO(GYP) nacl_integration
       # TODO(GYP) telemetry_perf_unittests
       # TODO(GYP) telemetry_unittests
     ]
   }
 }