Implement SharedArrayBuffer

src/objects.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_OBJECTS_H_
 #define V8_OBJECTS_H_
 
 #include <iosfwd>
 
 #include "src/allocation.h"
@@ skipping 156 matching lines @@
   STORE_AND_GROW_TRANSITION_SMI_TO_DOUBLE,
   STORE_AND_GROW_TRANSITION_DOUBLE_TO_OBJECT,
   STORE_AND_GROW_TRANSITION_HOLEY_SMI_TO_OBJECT,
   STORE_AND_GROW_TRANSITION_HOLEY_SMI_TO_DOUBLE,
   STORE_AND_GROW_TRANSITION_HOLEY_DOUBLE_TO_OBJECT,
   STORE_NO_TRANSITION_IGNORE_OUT_OF_BOUNDS,
   STORE_NO_TRANSITION_HANDLE_COW
 };
 
 
+enum SharedFlag { NOT_SHARED, SHARED };

[jochen (gone - plz use gerrit), 2015/05/22 08:37:47]

not needed?

[binji, 2015/05/22 09:27:34]

It was suggested in the other CL that this would make some of the callsites
clearer. But no, not strictly needed. Wdyt?

[Jarin, 2015/05/22 09:37:35]

Indeed, I suggested that for making it clear at call sites what the argument
does. We do this in other parts of v8 and I like that. (And it was suggested to
me to use enum for function arguments when I joined v8). 

Some related reading material:
https://existentialtype.wordpress.com/2011/03/15/boolean-blindness/

+
+
 enum ContextualMode {
   NOT_CONTEXTUAL,
   CONTEXTUAL
 };
 
 
 enum MutableMode {
   MUTABLE,
   IMMUTABLE
 };
@@ skipping 10086 matching lines @@
 
   inline bool is_external();
   inline void set_is_external(bool value);
 
   inline bool is_neuterable();
   inline void set_is_neuterable(bool value);
 
   inline bool was_neutered();
   inline void set_was_neutered(bool value);
 
+  inline bool is_shared();
+  inline void set_is_shared(bool value);
+
   DECLARE_CAST(JSArrayBuffer)
 
   void Neuter();
 
   // Dispatched behavior.
   DECLARE_PRINTER(JSArrayBuffer)
   DECLARE_VERIFIER(JSArrayBuffer)
 
   static const int kBackingStoreOffset = JSObject::kHeaderSize;
   static const int kByteLengthOffset = kBackingStoreOffset + kPointerSize;
   static const int kBitFieldSlot = kByteLengthOffset + kPointerSize;
 #if V8_TARGET_LITTLE_ENDIAN || !V8_HOST_ARCH_64_BIT
   static const int kBitFieldOffset = kBitFieldSlot;
 #else
   static const int kBitFieldOffset = kBitFieldSlot + kIntSize;
 #endif
   static const int kSize = kBitFieldSlot + kPointerSize;
 
   static const int kSizeWithInternalFields =
       kSize + v8::ArrayBuffer::kInternalFieldCount * kPointerSize;
 
   class IsExternal : public BitField<bool, 1, 1> {};
   class IsNeuterable : public BitField<bool, 2, 1> {};
   class WasNeutered : public BitField<bool, 3, 1> {};
+  class IsShared : public BitField<bool, 4, 1> {};
 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(JSArrayBuffer);
 };
 
 
 class JSArrayBufferView: public JSObject {
  public:
   // [buffer]: ArrayBuffer that this typed array views.
   DECL_ACCESSORS(buffer, Object)
@@ skipping 813 matching lines @@
     } else {
       value &= ~(1 << bit_position);
     }
     return value;
   }
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_OBJECTS_H_