Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1136553004: Remove CompositorSoftwareOutputDevice (Closed)

Created:
5 years, 7 months ago by jbauman
Modified:
5 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, piman+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove CompositorSoftwareOutputDevice This was only used in tests. In that case there's no reason to send the contents to another process, so we can use the simpler cc::SoftwareOutputDevice instead. Committed: https://crrev.com/7e15c6af85005fb44e35f2b1e3bfa1d61c4e2826 Cr-Commit-Position: refs/heads/master@{#329272}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -337 lines) Patch
M content/content_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D content/renderer/gpu/compositor_software_output_device.h View 1 chunk +0 lines, -101 lines 0 comments Download
D content/renderer/gpu/compositor_software_output_device.cc View 1 chunk +0 lines, -232 lines 0 comments Download
M content/renderer/render_widget.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbauman
5 years, 7 months ago (2015-05-08 19:36:52 UTC) #2
piman
lgtm
5 years, 7 months ago (2015-05-11 20:55:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136553004/1
5 years, 7 months ago (2015-05-11 21:39:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 23:43:19 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 23:44:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e15c6af85005fb44e35f2b1e3bfa1d61c4e2826
Cr-Commit-Position: refs/heads/master@{#329272}

Powered by Google App Engine
This is Rietveld 408576698