Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 1136543004: Remove two notification browsertests related to infobars. (Closed)

Created:
5 years, 7 months ago by Peter Beverloo
Modified:
5 years, 7 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, peter+watch_chromium.org, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove two notification browsertests related to infobars. There's no special logic for this behavior in the Notifications implementations that's not covered elsewhere. Given that the test was timing out as well, let's remove them. BUG=168976 Committed: https://crrev.com/a6dabae22b27c4dd8ad9daaa1d360f8bef7948b4 Cr-Commit-Position: refs/heads/master@{#329397}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M chrome/browser/notifications/notification_browsertest.cc View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Peter Beverloo
+stevenjb
5 years, 7 months ago (2015-05-11 18:11:12 UTC) #2
stevenjb
lgtm
5 years, 7 months ago (2015-05-11 23:53:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136543004/1
5 years, 7 months ago (2015-05-12 13:17:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 13:21:18 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 13:22:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6dabae22b27c4dd8ad9daaa1d360f8bef7948b4
Cr-Commit-Position: refs/heads/master@{#329397}

Powered by Google App Engine
This is Rietveld 408576698