sync/protocol/proto_value_conversions.cc - Issue 1136543003: Extensions: Store disable reasons in Sync

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/protocol/proto_value_conversions.cc

Issue 1136543003: Extensions: Store disable reasons in Sync (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add test Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/protocol/proto_value_conversions.cc

diff --git a/sync/protocol/proto_value_conversions.cc b/sync/protocol/proto_value_conversions.cc

index 1e74474180732e5b2fa6363dd429ac9252274e3c..1010ff128c310ee97e74c4efb756280904b50740 100644

--- a/sync/protocol/proto_value_conversions.cc

+++ b/sync/protocol/proto_value_conversions.cc

@@ -459,6 +459,7 @@ scoped_ptr<base::DictionaryValue> ExtensionSpecificsToValue(

SET_BOOL(remote_install);

SET_BOOL(installed_by_custodian);

SET_BOOL(all_urls_enabled);

+ SET_INT32(disable_reasons);

SET_STR(name);

not at google - send to devlin 2015/05/12 18:04:17 Kinda weird that the name is initialised out of or

Marc Treib 2015/05/19 12:12:03 Indeed. I've moved it inline to correspond to the

return value;

}