chrome/browser/apps/ephemeral_app_browsertest.cc - Issue 1136543003: Extensions: Store disable reasons in Sync

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/ephemeral_app_browsertest.cc

Issue 1136543003: Extensions: Store disable reasons in Sync (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix memleak in test Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/apps/ephemeral_app_browsertest.cc

diff --git a/chrome/browser/apps/ephemeral_app_browsertest.cc b/chrome/browser/apps/ephemeral_app_browsertest.cc

index 28046323f86820cade234d69e7987a91aaf44c54..07e01b5707ead07dd7a2818a0b4d980f5738c390 100644

--- a/chrome/browser/apps/ephemeral_app_browsertest.cc

+++ b/chrome/browser/apps/ephemeral_app_browsertest.cc

@@ -483,10 +483,12 @@ class EphemeralAppBrowserTest : public EphemeralAppTestBase {

ASSERT_TRUE(app);

// Simulate an install from sync.

+ int disable_reasons = enable_from_sync ? 0 : Extension::DISABLE_USER_ACTION;

const syncer::StringOrdinal kAppLaunchOrdinal("x");

const syncer::StringOrdinal kPageOrdinal("y");

AppSyncData app_sync_data(*app,

enable_from_sync,

+ disable_reasons,

false /* incognito enabled */,

false /* remote install */,

extensions::ExtensionSyncData::BOOLEAN_UNSET,