Issue 113653004: Removing GitDefaultProfile occurences from the remaining WebUI areas (mobile & test)

Issue 113653004: Removing GitDefaultProfile occurences from the remaining WebUI areas (mobile & test) (Closed)

Created:
7 years ago by Mr4D (OOO till 08-26)

Modified:
6 years, 11 months ago

Reviewers:
Dmitry Polukhin, Nikita (slow)

CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Removing GitDefaultProfile occurences from the remaining WebUI areas (mobile & test) BUG=322682 TEST=covered by existing unit tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243468

Patch Set 1 #

Total comments: 2

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -5 lines)			Patch
M	chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc	View	1 chunk	+2 lines, -2 lines	2 comments	Download
M	chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mr4D (OOO till 08-26)

Removed these three places which were somehow not covered yet. As designed I leave the ...

7 years ago (2013-12-20 19:28:01 UTC) #1

Nikita (slow)

lgtm https://codereview.chromium.org/113653004/diff/1/chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc File chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc (right): https://codereview.chromium.org/113653004/diff/1/chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc#newcode101 chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc:101: // Only the primary user can change this. ...

7 years ago (2013-12-23 12:12:21 UTC) #2

Mr4D (OOO till 08-26)

Thanks! https://codereview.chromium.org/113653004/diff/1/chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc File chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc (right): https://codereview.chromium.org/113653004/diff/1/chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc#newcode101 chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc:101: // Only the primary user can change this. ...

6 years, 11 months ago (2014-01-07 23:29:34 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/113653004/1

6 years, 11 months ago (2014-01-07 23:35:28 UTC) #4

Message was sent while issue was closed.

Change committed as 243468

Expand Messages | Collapse Messages