runtime/vm/dart_api_impl_test.cc - Issue 11365243: Revert OneByteString back to ISO Latin-1 instead of ASCII

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl_test.cc

Issue 11365243: Revert OneByteString back to ISO Latin-1 instead of ASCII (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart_api_impl_test.cc

===================================================================

--- runtime/vm/dart_api_impl_test.cc (revision 14800)

+++ runtime/vm/dart_api_impl_test.cc (working copy)

@@ -518,7 +518,7 @@

Dart_Handle str8 = Dart_NewStringFromUTF8(data8, ARRAY_SIZE(data8));

EXPECT_VALID(str8);

EXPECT(Dart_IsString(str8));

- EXPECT(Dart_IsAsciiString(str8));

+ EXPECT(Dart_IsISOLatin1String(str8));

EXPECT(!Dart_IsExternalString(str8));

Dart_Handle ext8 = Dart_NewExternalUTF8String(data8, ARRAY_SIZE(data8),

@@ -532,7 +532,7 @@

Dart_Handle str16 = Dart_NewStringFromUTF16(data16, ARRAY_SIZE(data16));

EXPECT_VALID(str16);

EXPECT(Dart_IsString(str16));

- EXPECT(!Dart_IsAsciiString(str16));

+ EXPECT(!Dart_IsISOLatin1String(str16));

EXPECT(!Dart_IsExternalString(str16));

Dart_Handle ext16 = Dart_NewExternalUTF16String(data16, ARRAY_SIZE(data16),

« runtime/include/dart_api.h ('K') | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »