Revert OneByteString back to ISO Latin-1 instead of ASCII

runtime/vm/dart_api_impl_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/json.h"
 #include "platform/utils.h"
 #include "vm/class_finalizer.h"
 #include "vm/dart_api_impl.h"
@@ skipping 500 matching lines @@
   }
 }
 
 
 TEST_CASE(IsString) {
   uint8_t data8[] = { 'o', 'n', 'e', 0x7F };
 
   Dart_Handle str8 = Dart_NewStringFromUTF8(data8, ARRAY_SIZE(data8));
   EXPECT_VALID(str8);
   EXPECT(Dart_IsString(str8));
-  EXPECT(Dart_IsAsciiString(str8));
+  EXPECT(Dart_IsStringLatin1(str8));
   EXPECT(!Dart_IsExternalString(str8));
 
   Dart_Handle ext8 = Dart_NewExternalUTF8String(data8, ARRAY_SIZE(data8),
                                                 NULL, NULL);
   EXPECT_VALID(ext8);
   EXPECT(Dart_IsString(ext8));
   EXPECT(Dart_IsExternalString(ext8));
 
   uint16_t data16[] = { 't', 'w', 'o', 0xFFFF };
 
   Dart_Handle str16 = Dart_NewStringFromUTF16(data16, ARRAY_SIZE(data16));
   EXPECT_VALID(str16);
   EXPECT(Dart_IsString(str16));
-  EXPECT(!Dart_IsAsciiString(str16));
+  EXPECT(!Dart_IsStringLatin1(str16));
   EXPECT(!Dart_IsExternalString(str16));
 
   Dart_Handle ext16 = Dart_NewExternalUTF16String(data16, ARRAY_SIZE(data16),
                                                   NULL, NULL);
   EXPECT_VALID(ext16);
   EXPECT(Dart_IsString(ext16));
   EXPECT(Dart_IsExternalString(ext16));
 
   uint32_t data32[] = { 'f', 'o', 'u', 'r', 0x10FFFF };
 
@@ skipping 6710 matching lines @@
     EXPECT(Dart_IsString(empty_str));
     EXPECT(!Dart_IsExternalString(empty_str));
     uint8_t ext_empty_str[kLength];
     Dart_Handle str = Dart_MakeExternalString(empty_str,
                                               ext_empty_str,
                                               kLength,
                                               NULL,
                                               NULL);
     EXPECT(Dart_IsString(str));
     EXPECT(Dart_IsString(empty_str));
-    EXPECT(Dart_IsAsciiString(str));
-    EXPECT(Dart_IsAsciiString(empty_str));
+    EXPECT(Dart_IsStringLatin1(str));
+    EXPECT(Dart_IsStringLatin1(empty_str));
     EXPECT(Dart_IsExternalString(str));
     EXPECT(Dart_IsExternalString(empty_str));
     EXPECT_VALID(Dart_StringLength(str, &length));
     EXPECT_EQ(0, length);
 
     // Test with a one byte ascii string.
     const char* ascii = "string";
     expected_length = strlen(ascii);
     Dart_Handle ascii_str = NewString(ascii);
     EXPECT_VALID(ascii_str);
     EXPECT(Dart_IsString(ascii_str));
-    EXPECT(Dart_IsAsciiString(ascii_str));
+    EXPECT(Dart_IsStringLatin1(ascii_str));
     EXPECT(!Dart_IsExternalString(ascii_str));
     EXPECT_VALID(Dart_StringLength(ascii_str, &length));
     EXPECT_EQ(expected_length, length);
 
     uint8_t ext_ascii_str[kLength];
     EXPECT_VALID(Dart_StringStorageSize(ascii_str, &size));
     str = Dart_MakeExternalString(ascii_str,
                                   ext_ascii_str,
                                   size,
                                   &peer8,
                                   MakeExternalCback);
     EXPECT(Dart_IsString(str));
     EXPECT(Dart_IsString(ascii_str));
-    EXPECT(Dart_IsAsciiString(str));
-    EXPECT(Dart_IsAsciiString(ascii_str));
+    EXPECT(Dart_IsStringLatin1(str));
+    EXPECT(Dart_IsStringLatin1(ascii_str));
     EXPECT(Dart_IsExternalString(str));
     EXPECT(Dart_IsExternalString(ascii_str));
     EXPECT_VALID(Dart_StringLength(str, &length));
     EXPECT_EQ(expected_length, length);
     EXPECT_VALID(Dart_StringLength(ascii_str, &length));
     EXPECT_EQ(expected_length, length);
     EXPECT(Dart_IdentityEquals(str, ascii_str));
     for (intptr_t i = 0; i < length; i++) {
       EXPECT_EQ(ascii[i], ext_ascii_str[i]);
     }
 
     uint8_t data[] = { 0xE4, 0xBA, 0x8c };  // U+4E8C.
     expected_length = 1;
     Dart_Handle utf16_str = Dart_NewStringFromUTF8(data, ARRAY_SIZE(data));
     EXPECT_VALID(utf16_str);
     EXPECT(Dart_IsString(utf16_str));
-    EXPECT(!Dart_IsAsciiString(utf16_str));
+    EXPECT(!Dart_IsStringLatin1(utf16_str));
     EXPECT(!Dart_IsExternalString(utf16_str));
     EXPECT_VALID(Dart_StringLength(utf16_str, &length));
     EXPECT_EQ(expected_length, length);
 
     // Test with a two byte string.
     uint16_t ext_utf16_str[kLength];
     EXPECT_VALID(Dart_StringStorageSize(utf16_str, &size));
     str = Dart_MakeExternalString(utf16_str,
                                   ext_utf16_str,
                                   size,
                                   &peer16,
                                   MakeExternalCback);
     EXPECT(Dart_IsString(str));
     EXPECT(Dart_IsString(utf16_str));
-    EXPECT(!Dart_IsAsciiString(str));
-    EXPECT(!Dart_IsAsciiString(utf16_str));
+    EXPECT(!Dart_IsStringLatin1(str));
+    EXPECT(!Dart_IsStringLatin1(utf16_str));
     EXPECT(Dart_IsExternalString(str));
     EXPECT(Dart_IsExternalString(utf16_str));
     EXPECT_VALID(Dart_StringLength(str, &length));
     EXPECT_EQ(expected_length, length);
     EXPECT_VALID(Dart_StringLength(utf16_str, &length));
     EXPECT_EQ(expected_length, length);
     EXPECT(Dart_IdentityEquals(str, utf16_str));
     for (intptr_t i = 0; i < length; i++) {
       EXPECT_EQ(0x4e8c, ext_utf16_str[i]);
     }
@@ skipping 42 matching lines @@
   Dart_LoadSource(TestCase::lib(), url, source);
 
   dart_args[0] = Dart_NewInteger(1);
   result = Dart_Invoke(lib1, NewString("start"), 1, dart_args);
   EXPECT_VALID(result);
 }
 
 #endif  // defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64).
 
 }  // namespace dart