Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7635)

Unified Diff: cc/layer_impl.h

Issue 11365239: cc: Add support for debugging layer borders directly in the compositor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layer.cc ('k') | cc/layer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layer_impl.h
diff --git a/cc/layer_impl.h b/cc/layer_impl.h
index f773c138e462196cc0b56acb725c3407317a57c2..4ad427e9b19d89811c15f151b1169e8cf20c6c9f 100644
--- a/cc/layer_impl.h
+++ b/cc/layer_impl.h
@@ -145,17 +145,12 @@ public:
void setSublayerTransform(const WebKit::WebTransformationMatrix&);
const WebKit::WebTransformationMatrix& sublayerTransform() const { return m_sublayerTransform; }
- // Debug layer border - visual effect only, do not change geometry/clipping/etc.
- void setDebugBorderColor(SkColor);
- SkColor debugBorderColor() const { return m_debugBorderColor; }
- void setDebugBorderWidth(float);
- float debugBorderWidth() const { return m_debugBorderWidth; }
- bool hasDebugBorders() const;
-
// Debug layer name.
void setDebugName(const std::string& debugName) { m_debugName = debugName; }
std::string debugName() const { return m_debugName; }
+ bool showDebugBorders() const;
+
RenderSurfaceImpl* renderSurface() const { return m_renderSurface.get(); }
void createRenderSurface();
void clearRenderSurface() { m_renderSurface.reset(); }
@@ -280,6 +275,9 @@ public:
protected:
explicit LayerImpl(int);
+ // Get the color and size of the layer's debug border.
+ virtual void getDebugBorderProperties(SkColor*, float* width) const;
+
void appendDebugBorderQuad(QuadSink&, const SharedQuadState*, AppendQuadsData&) const;
virtual void dumpLayerProperties(std::string*, int indent) const;
@@ -374,10 +372,6 @@ private:
float m_drawOpacity;
bool m_drawOpacityIsAnimating;
- // Debug borders.
- SkColor m_debugBorderColor;
- float m_debugBorderWidth;
-
// Debug layer name.
std::string m_debugName;
« no previous file with comments | « cc/layer.cc ('k') | cc/layer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698