Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1136523008: Revert "dart2js cps: Introduce GetStatic/SetStatic." (Closed)

Created:
5 years, 7 months ago by asgerf
Modified:
5 years, 7 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Revert "dart2js cps: Introduce GetStatic/SetStatic." This reverts commit 28e4518df87c72cb8e23fe6d73b7750ad0f2183a. TBR=karlklose@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45737

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4043 lines, -4018 lines) Patch
M pkg/analyzer2dart/test/sexpr_data.dart View 4 chunks +14 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 3 chunks +15 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 2 chunks +1 line, -5 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 5 chunks +1 line, -43 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart View 3 chunks +0 lines, -20 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart View 1 chunk +0 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 3 chunks +36 lines, -26 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/glue.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart View 1 chunk +0 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart View 5 chunks +2 lines, -42 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart View 1 chunk +0 lines, -11 lines 0 comments Download
M pkg/pkg.status View 1 chunk +49 lines, -49 lines 0 comments Download
M runtime/tests/vm/vm.status View 1 chunk +1 line, -1 line 0 comments Download
M samples/samples.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +2159 lines, -2039 lines 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 3 chunks +6 lines, -0 lines 0 comments Download
M tests/compiler/dart2js_native/dart2js_native.status View 2 chunks +2 lines, -0 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +153 lines, -155 lines 0 comments Download
M tests/html/html.status View 1 chunk +144 lines, -144 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +60 lines, -38 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +931 lines, -908 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +362 lines, -350 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +104 lines, -93 lines 0 comments Download
M tests/utils/utils.status View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
asgerf
Committed patchset #1 (id:1) manually as 45737 (presubmit successful).
5 years, 7 months ago (2015-05-12 13:53:51 UTC) #1
karlklose
5 years, 7 months ago (2015-05-12 14:04:47 UTC) #2
Message was sent while issue was closed. 
LGTM.

Powered by Google App Engine
This is Rietveld 408576698