build/android/findbugs_filter/findbugs_known_bugs.txt - Issue 11365199: Move WebContentsDelegateAndroid to content/components

Unified Diff: build/android/findbugs_filter/findbugs_known_bugs.txt

Issue 11365199: Move WebContentsDelegateAndroid to content/components (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address John's comments. Adjust findbugs suppression. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/findbugs_filter/findbugs_known_bugs.txt

diff --git a/build/android/findbugs_filter/findbugs_known_bugs.txt b/build/android/findbugs_filter/findbugs_known_bugs.txt

index 7e0de335b9bd33e944e24a0057ebca341b8dede3..3b6ac322151618be21d9a55aea59e4e3025317f9 100644

--- a/build/android/findbugs_filter/findbugs_known_bugs.txt

+++ b/build/android/findbugs_filter/findbugs_known_bugs.txt

@@ -187,7 +187,7 @@ M P SS: Unread field: org.chromium.android_webview.test.util.ImagePageGenerator.

M P SS: Unread field: org.chromium.android_webview.test.util.ImagePageGenerator.IMAGE_SUFFIX; should this field be static? At ImagePageGenerator.java

M P SS: Unread field: org.chromium.native_test.ChromeNativeTestActivity.EXTRA_RUN_IN_SUB_THREAD; should this field be static? At ChromeNativeTestActivity.java

M P SS: Unread field: org.chromium.native_test.ChromeNativeTestActivity.TAG; should this field be static? At ChromeNativeTestActivity.java

-M P UPM: Private method org.chromium.chrome.browser.component.web_contents_delegate_android.WebContentsDelegateAndroid.onLoadProgressChanged(double) is never called At WebContentsDelegateAndroid.java

+M P UPM: Private method org.chromium.content.components.web_contents_delegate_android.WebContentsDelegateAndroid.onLoadProgressChanged(double) is never called At WebContentsDelegateAndroid.java

joth 2012/11/13 19:26:14 I'm surprised this is the only example of this war

John Knottenbelt 2012/11/14 10:53:28 Indeed, it is rather mysterious. Will take a look

John Knottenbelt 2012/11/14 12:22:59 I investigated this some more. The warning disappe

M P UrF: Unread field: org.chromium.content.browser.ContentViewGestureHandlerTest$MockListener.mLastFling2 At ContentViewGestureHandlerTest.java

M P UrF: Unread field: org.chromium.content.browser.ContentViewGestureHandlerTest$MockListener.mLastScroll1 At ContentViewGestureHandlerTest.java

M P UrF: Unread field: org.chromium.content.browser.ContentViewGestureHandlerTest$MockListener.mLastScroll2 At ContentViewGestureHandlerTest.java

« no previous file with comments | « android_webview/native/webview_native.gyp ('k') | chrome/android/java/DEPS » ('j') | chrome/chrome_browser.gypi » ('J')