sdk/lib/_internal/compiler/implementation/dart2js.dart - Issue 11365196: Move JSSyntaxRegExp to core as a private member. This removes the last refrences to dart:coreimpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/dart2js.dart

Issue 11365196: Move JSSyntaxRegExp to core as a private member. This removes the last refrences to dart:coreimpl. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Change arrow-syntax factory into brace-syntax, due to multiline content. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/compiler.dart ('K') | « sdk/lib/_internal/compiler/implementation/compiler.dart ('k') | sdk/lib/_internal/compiler/implementation/js/printer.dart » ('j') | sdk/lib/core/sort.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/dart2js.dart

diff --git a/sdk/lib/_internal/compiler/implementation/dart2js.dart b/sdk/lib/_internal/compiler/implementation/dart2js.dart

index f6a91d73f10f84ed15452887f99e328b6f9217f4..423a40fded1807ce9786eb9b3a0e5760b19c67cf 100644

--- a/sdk/lib/_internal/compiler/implementation/dart2js.dart

+++ b/sdk/lib/_internal/compiler/implementation/dart2js.dart

@@ -35,7 +35,7 @@ class OptionHandler {

String extractParameter(String argument) {

// m[0] is the entire match (which will be equal to argument). m[1]

// is something like "-o" or "--out=", and m[2] is the parameter.

- Match m = const RegExp('^(-[a-z]|--.+=)(.*)').firstMatch(argument);

+ Match m = new RegExp('^(-[a-z]|--.+=)(.*)').firstMatch(argument);

if (m == null) helpAndFail('Error: Unknown option "$argument".');

return m[2];

}