sdk/lib/_internal/compiler/implementation/native_handler.dart - Issue 11365196: Move JSSyntaxRegExp to core as a private member. This removes the last refrences to dart:coreimpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/native_handler.dart

Issue 11365196: Move JSSyntaxRegExp to core as a private member. This removes the last refrences to dart:coreimpl. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Make VM's JSSyntaxRegExp private. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« runtime/lib/regexp_patch.dart ('K') | « sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart ('k') | sdk/lib/_internal/compiler/implementation/resolution/members.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/native_handler.dart

diff --git a/sdk/lib/_internal/compiler/implementation/native_handler.dart b/sdk/lib/_internal/compiler/implementation/native_handler.dart

index 0ba42aea08f475ea08ac938302867d44a04d2ed6..8d6b9eb585cec27c48329bbd49ad5c88ea27713e 100644

--- a/sdk/lib/_internal/compiler/implementation/native_handler.dart

+++ b/sdk/lib/_internal/compiler/implementation/native_handler.dart

@@ -211,7 +211,7 @@ void handleSsaNative(SsaBuilder builder, Expression nativeBody) {

// 1) foo() native; hasBody = false, isRedirecting = false

// 2) foo() native "bar"; hasBody = false, isRedirecting = true

// 3) foo() native "return 42"; hasBody = true, isRedirecting = false

- RegExp nativeRedirectionRegExp = const RegExp(r'^[a-zA-Z][a-zA-Z_$0-9]*$');

+ RegExp nativeRedirectionRegExp = new RegExp(r'^[a-zA-Z][a-zA-Z_$0-9]*$');

bool hasBody = false;

bool isRedirecting = false;

String nativeMethodName = element.name.slowToString();