sdk/lib/_internal/compiler/implementation/js/printer.dart - Issue 11365196: Move JSSyntaxRegExp to core as a private member. This removes the last refrences to dart:coreimpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js/printer.dart

Issue 11365196: Move JSSyntaxRegExp to core as a private member. This removes the last refrences to dart:coreimpl. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Make VM's JSSyntaxRegExp private. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« runtime/lib/regexp_patch.dart ('K') | « sdk/lib/_internal/compiler/implementation/dart2js.dart ('k') | sdk/lib/_internal/compiler/implementation/lib/core_patch.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js/printer.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js/printer.dart b/sdk/lib/_internal/compiler/implementation/js/printer.dart

index 5bdbfd98b0c2ca90f35c197b7fbd5bee717579f5..21b9e779b40d2dd407e6df6af6a70a2b67cb3f9a 100644

--- a/sdk/lib/_internal/compiler/implementation/js/printer.dart

+++ b/sdk/lib/_internal/compiler/implementation/js/printer.dart

@@ -46,7 +46,7 @@ class Printer implements NodeVisitor {

void out(String str) {

if (str != "") {

- const identifierRegexp = const RegExp(r'^[a-zA-Z_0-9$]');

+ final identifierRegexp = new RegExp(r'^[a-zA-Z_0-9$]');

if (pendingSemicolon && (!shouldCompressOutput || str != "}")) {

outBuffer.add(";");

}

@@ -1067,7 +1067,7 @@ class MinifyRenamer implements Namer {

codes.add(charCodes.$0 + digit);

newName = new String.fromCharCodes(codes);

}

- assert(const RegExp(r'[a-zA-Z][a-zA-Z0-9]*').hasMatch(newName));

+ assert(new RegExp(r'[a-zA-Z][a-zA-Z0-9]*').hasMatch(newName));

maps.last[oldName] = newName;

return newName;

}