Move JSSyntaxRegExp to core as a private member. This removes the last refrences to dart:coreimpl.

runtime/vm/parser.cc

Index: runtime/vm/parser.cc
diff --git a/runtime/vm/parser.cc b/runtime/vm/parser.cc
index 9dc93dbc571560696e6bec625f7779c805d23ee3..ec9000e71b6dcae5ff87d044d598bfcb3e8f32d9 100644
--- a/runtime/vm/parser.cc
+++ b/runtime/vm/parser.cc
@@ -1367,14 +1367,6 @@ RawFunction* Parser::GetSuperFunction(intptr_t token_pos,
 }
 
 
-// Lookup class in the corelib implementation which contains various VM
-// helper methods and classes.
-static RawClass* LookupImplClass(const String& class_name) {
-  Library& coreimpl = Library::Handle(Library::CoreImplLibrary());
-  return coreimpl.LookupClassAllowPrivate(class_name);
-}
-
-
 // Lookup class in the core lib which also contains various VM
 // helper methods and classes. Allow look up of private classes.
 static RawClass* LookupCoreClass(const String& class_name) {
@@ -9021,7 +9013,7 @@ AstNode* Parser::ParseMapLiteral(intptr_t type_pos,
     const String& immutable_map_class_name =
         String::Handle(Symbols::ImmutableMap());
     const Class& immutable_map_class =
-        Class::Handle(LookupImplClass(immutable_map_class_name));
+        Class::Handle(LookupCoreClass(immutable_map_class_name));

[Ivan Posva, 2012/11/13 18:26:28]

I do not see the immutable map class moving from coreimpl to core in this
change, how did that work?

[Anders Johnsen, 2012/11/13 18:40:26]

Agreed, and this is something that I didn't detect earlier on. This is 100% my
error to not have detected this correctly in an earlier commit (a few weeks
ago). Nonetheless, status quo is that coreimpl doesn't exist anymore.

     ASSERT(!immutable_map_class.IsNull());
     ArgumentListNode* constr_args = new ArgumentListNode(TokenPos());
     constr_args->Add(new LiteralNode(literal_pos, key_value_array));