Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: runtime/vm/intrinsifier.cc

Issue 11365196: Move JSSyntaxRegExp to core as a private member. This removes the last refrences to dart:coreimpl. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix two pending TODO's. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intrinsifier.cc
diff --git a/runtime/vm/intrinsifier.cc b/runtime/vm/intrinsifier.cc
index 007ac57b863754feca25c85650ba2065e219c2c3..59adb5cace67d88e6bd8d5bed0ae5d7e5e1b2977 100644
--- a/runtime/vm/intrinsifier.cc
+++ b/runtime/vm/intrinsifier.cc
@@ -17,10 +17,9 @@ static bool CompareNames(const char* test_name, const char* name) {
return true;
}
if ((name[0] == '_') && (test_name[0] == '_')) {
- // Check if the private class is member of core, coreimpl or
- // scalarlist and matches the test_class_name.
+ // Check if the private class is member of core or scalarlist and matches
+ // the test_class_name.
const Library& core_lib = Library::Handle(Library::CoreLibrary());
- const Library& core_impl_lib = Library::Handle(Library::CoreImplLibrary());
const Library& scalarlist_lib =
Library::Handle(Library::ScalarlistLibrary());
String& test_str = String::Handle(String::New(test_name));
@@ -31,11 +30,6 @@ static bool CompareNames(const char* test_name, const char* name) {
return true;
}
test_str_with_key =
- String::Concat(test_str, String::Handle(core_impl_lib.private_key()));
- if (strcmp(test_str_with_key.ToCString(), name) == 0) {
- return true;
- }
- test_str_with_key =
String::Concat(test_str, String::Handle(scalarlist_lib.private_key()));
if (strcmp(test_str_with_key.ToCString(), name) == 0) {
return true;
@@ -78,7 +72,6 @@ bool Intrinsifier::CanIntrinsify(const Function& function) {
const Class& function_class = Class::Handle(function.Owner());
// Only core, math and scalarlist library methods can be intrinsified.
if ((function_class.library() != Library::CoreLibrary()) &&
- (function_class.library() != Library::CoreImplLibrary()) &&
(function_class.library() != Library::MathLibrary()) &&
(function_class.library() != Library::ScalarlistLibrary())) {
return false;

Powered by Google App Engine
This is Rietveld 408576698