Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Unified Diff: runtime/vm/class_finalizer.cc

Issue 11365196: Move JSSyntaxRegExp to core as a private member. This removes the last refrences to dart:coreimpl. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix two pending TODO's. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/class_finalizer.cc
diff --git a/runtime/vm/class_finalizer.cc b/runtime/vm/class_finalizer.cc
index c0941ac014228715b4a26bfbd3c21b0eba3432e8..d3e806278a73e0e6f5dff374a0c2b41bca3adb8a 100644
--- a/runtime/vm/class_finalizer.cc
+++ b/runtime/vm/class_finalizer.cc
@@ -252,8 +252,7 @@ void ClassFinalizer::ResolveSuperType(const Class& cls) {
}
// If cls belongs to core lib or to core lib's implementation, restrictions
// about allowed interfaces are lifted.
- if ((cls.library() != Library::CoreLibrary()) &&
- (cls.library() != Library::CoreImplLibrary())) {
+ if (cls.library() != Library::CoreLibrary()) {
// Prevent extending core implementation classes.
bool is_error = false;
switch (super_class.id()) {
@@ -1389,9 +1388,7 @@ void ClassFinalizer::ResolveInterfaces(const Class& cls,
// If cls belongs to core lib or to core lib's implementation, restrictions
// about allowed interfaces are lifted.
- const bool cls_belongs_to_core_lib =
- (cls.library() == Library::CoreLibrary()) ||
- (cls.library() == Library::CoreImplLibrary());
+ const bool cls_belongs_to_core_lib = cls.library() == Library::CoreLibrary();
// Resolve and check the interfaces of cls.
visited->Add(cls_index);

Powered by Google App Engine
This is Rietveld 408576698