runtime/lib/lib_sources.gypi - Issue 11365196: Move JSSyntaxRegExp to core as a private member. This removes the last refrences to dart:coreimpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/lib_sources.gypi

Issue 11365196: Move JSSyntaxRegExp to core as a private member. This removes the last refrences to dart:coreimpl. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fix two pending TODO's. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/lib_sources.gypi

diff --git a/runtime/lib/lib_sources.gypi b/runtime/lib/lib_sources.gypi

index a85f3d856f7f23b00d3632aee57205951a69254d..5dd5b7ff5a079d4788b8e4f74abfd127e622b356 100644

--- a/runtime/lib/lib_sources.gypi

+++ b/runtime/lib/lib_sources.gypi

@@ -28,8 +28,15 @@

'integers_patch.dart',

'invocation_mirror_patch.dart',

'literal_factory.dart',

+ 'math.dart',

Ivan Posva 2012/11/13 18:26:28 Why was this moved here? The functions in this fil

Anders Johnsen 2012/11/13 18:40:26 It lived in coreimpl before, so that's why it was

Mads Ager (google) 2012/11/14 10:32:31 The problem is not the move. The problem is that M

+ 'math.cc',

+ 'object.cc',

'object_patch.dart',

'print_patch.dart',

+ 'regexp.cc',

+ 'regexp_jsc.cc',

+ 'regexp_jsc.h',

+ 'regexp_patch.dart',

'stopwatch_patch.dart',

'stopwatch.cc',

'string.cc',

« no previous file with comments | « runtime/lib/lib_impl_sources.gypi ('k') | runtime/lib/regexp_patch.dart » ('j') | runtime/vm/bootstrap_natives.cc » ('J')