Move JSSyntaxRegExp to core as a private member. This removes the last refrences to dart:coreimpl.

runtime/vm/snapshot_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_debugger_api.h"
 #include "platform/assert.h"
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_api_message.h"
@@ skipping 849 matching lines @@
   }
 }
 
 TEST_CASE(GenerateSource) {
   Library& lib = Library::Handle();
   // Check core lib.
   lib = Library::CoreLibrary();
   EXPECT(!lib.IsNull());
   IterateScripts(lib);
 
-  // Check core impl lib.
-  lib = Library::CoreImplLibrary();
-  EXPECT(!lib.IsNull());
-  IterateScripts(lib);
-
   // Check isolate lib.
   lib = Library::IsolateLibrary();
   EXPECT(!lib.IsNull());
   IterateScripts(lib);
 
   // Check math lib.

[Ivan Posva, 2012/11/13 18:26:28]

?

[Anders Johnsen, 2012/11/13 18:40:26]

Bad merge.

   lib = Library::MathLibrary();
   EXPECT(!lib.IsNull());
   IterateScripts(lib);
 
   // Check mirrors lib.
   lib = Library::MirrorsLibrary();
   EXPECT(!lib.IsNull());
   IterateScripts(lib);
 }
 
@@ skipping 1207 matching lines @@
   EXPECT(Dart_ErrorHasException(result));
   EXPECT_SUBSTRING("Exception: nulltruefalse1234563.14[]100123456789\n",
                    Dart_GetError(result));
 
   Dart_ExitScope();
 }
 
 #endif  // defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64).
 
 }  // namespace dart