Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Side by Side Diff: runtime/vm/bootstrap_natives.cc

Issue 11365196: Move JSSyntaxRegExp to core as a private member. This removes the last refrences to dart:coreimpl. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix two pending TODO's. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/bootstrap.h" 5 #include "vm/bootstrap.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 8
9 #include "vm/bootstrap_natives.h" 9 #include "vm/bootstrap_natives.h"
10 #include "vm/dart_api_impl.h" 10 #include "vm/dart_api_impl.h"
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 void Bootstrap::SetupNativeResolver() { 53 void Bootstrap::SetupNativeResolver() {
54 Library& library = Library::Handle(); 54 Library& library = Library::Handle();
55 55
56 Dart_NativeEntryResolver resolver = 56 Dart_NativeEntryResolver resolver =
57 reinterpret_cast<Dart_NativeEntryResolver>(BootstrapNatives::Lookup); 57 reinterpret_cast<Dart_NativeEntryResolver>(BootstrapNatives::Lookup);
58 58
59 library = Library::CoreLibrary(); 59 library = Library::CoreLibrary();
60 ASSERT(!library.IsNull()); 60 ASSERT(!library.IsNull());
61 library.set_native_entry_resolver(resolver); 61 library.set_native_entry_resolver(resolver);
62 62
63 library = Library::CoreImplLibrary();
64 ASSERT(!library.IsNull());
65 library.set_native_entry_resolver(resolver);
66
67 library = Library::CollectionLibrary(); 63 library = Library::CollectionLibrary();
Ivan Posva 2012/11/13 18:26:28 Does the collection library have any native code?
Anders Johnsen 2012/11/13 18:40:26 This is actually not the change, it's a bad merge.
68 ASSERT(!library.IsNull()); 64 ASSERT(!library.IsNull());
69 library.set_native_entry_resolver(resolver); 65 library.set_native_entry_resolver(resolver);
70 66
71 library = Library::MirrorsLibrary(); 67 library = Library::MirrorsLibrary();
72 ASSERT(!library.IsNull()); 68 ASSERT(!library.IsNull());
73 library.set_native_entry_resolver(resolver); 69 library.set_native_entry_resolver(resolver);
74 70
75 library = Library::IsolateLibrary(); 71 library = Library::IsolateLibrary();
76 ASSERT(!library.IsNull()); 72 ASSERT(!library.IsNull());
77 library.set_native_entry_resolver(resolver); 73 library.set_native_entry_resolver(resolver);
78 74
79 library = Library::ScalarlistLibrary(); 75 library = Library::ScalarlistLibrary();
80 ASSERT(!library.IsNull()); 76 ASSERT(!library.IsNull());
81 library.set_native_entry_resolver(resolver); 77 library.set_native_entry_resolver(resolver);
82 } 78 }
83 79
84 } // namespace dart 80 } // namespace dart
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698