Issue 11365191: Merge 133550 - [Chromium] Unicode combining diacritical aren't always combined on Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11365191: Merge 133550 - [Chromium] Unicode combining diacritical aren't always combined on Linux (Closed)

Created:
8 years, 1 month ago by bashi

Modified:
8 years, 1 month ago

Reviewers:
bashi

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/

Visibility:
Public.

More Reviews

Description

Merge 133550 - [Chromium] Unicode combining diacritical aren't always combined on Linux https://bugs.webkit.org/show_bug.cgi?id=101009 Reviewed by Kent Tamura. Source/WebCore: Add a space character to harfbuzzBuffer as pre-context. This will prevent harfbuzz from inserting dotted-circle. Test: fast/text/international/combining-marks-position.html * platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp: (WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): LayoutTests: Add a test that checks whether combining marks are combined with base characters. * fast/text/international/combining-marks-position-expected.txt: Added. * fast/text/international/combining-marks-position.html: Added. TBR=bashi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134171

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, --2 lines)			Patch
A +	LayoutTests/fast/text/international/combining-marks-position.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/fast/text/international/combining-marks-position-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages