A change in the way we place TransitionElementKinds in the tree.

src/objects.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2288 matching lines @@
         transitioned_map = maybe_transitioned_map;
         if (!IsFastPackedElementsKind(kind)) packed = false;
       }
       current_map = maybe_transitioned_map;
     }
   }
   return transitioned_map;
 }
 
 
-static Map* FindClosestElementsTransition(Map* map, ElementsKind to_kind) {
+Map* FindClosestElementsTransition(Map* map, ElementsKind to_kind) {
   Map* current_map = map;
   int index = GetSequenceIndexFromFastElementsKind(map->elements_kind());
   int to_index = IsFastElementsKind(to_kind)
       ? GetSequenceIndexFromFastElementsKind(to_kind)
       : GetSequenceIndexFromFastElementsKind(TERMINAL_FAST_ELEMENTS_KIND);
 
   ASSERT(index <= to_index);
 
   for (; index < to_index; ++index) {
     if (!current_map->HasElementsTransition()) return current_map;
@@ skipping 10 matching lines @@
 }
 
 
 Map* Map::LookupElementsTransitionMap(ElementsKind to_kind) {
   Map* to_map = FindClosestElementsTransition(this, to_kind);
   if (to_map->elements_kind() == to_kind) return to_map;
   return NULL;
 }
 
 
-static MaybeObject* AddMissingElementsTransitions(Map* map,
-                                                  ElementsKind to_kind) {
+MaybeObject* AddMissingElementsTransitions(Map* map, ElementsKind to_kind) {

[danno, 2012/11/14 15:28:18]

Perhaps it is time to move this to be part of the Map class' interface?

[mvstanton, 2012/11/16 15:15:06]

Done.

   ASSERT(IsFastElementsKind(map->elements_kind()));
   int index = GetSequenceIndexFromFastElementsKind(map->elements_kind());
   int to_index = IsFastElementsKind(to_kind)
       ? GetSequenceIndexFromFastElementsKind(to_kind)
       : GetSequenceIndexFromFastElementsKind(TERMINAL_FAST_ELEMENTS_KIND);
 
   ASSERT(index <= to_index);
 
   Map* current_map = map;
 
@@ skipping 11506 matching lines @@
   set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER);
   set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER);
   set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER);
   set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER);
   set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER);
   set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER);
   set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER);
 }
 
 } }  // namespace v8::internal