ui/gfx/rect_f.h - Issue 11365160: ui: Remove gfx::Size::ClampToNonNegative, prevent negative sizes always.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/rect_f.h

Issue 11365160: ui: Remove gfx::Size::ClampToNonNegative, prevent negative sizes always. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix unit tests that use negative values or NaN Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gfx/rect_f.h

diff --git a/ui/gfx/rect_f.h b/ui/gfx/rect_f.h

index c9310194c34ffe23bd6f5c14a8a45cd2ed55e617..965e5afe107823e2d906c4780641c7d1f0431e6a 100644

--- a/ui/gfx/rect_f.h

+++ b/ui/gfx/rect_f.h

@@ -36,9 +36,8 @@ class UI_EXPORT RectF

void Scale(float x_scale, float y_scale) {

set_origin(ScalePoint(origin(), x_scale, y_scale));

- SizeF newSize = size().Scale(x_scale, y_scale);

- newSize.ClampToNonNegative();

- set_size(newSize);

+ SizeF new_size = size().Scale(x_scale, y_scale);

+ set_size(new_size);

}

// This method reports if the RectF can be safely converted to an integer

« no previous file with comments | « cc/draw_quad_unittest.cc ('k') | ui/gfx/rect_unittest.cc » ('j') | no next file with comments »