ui: Remove gfx::Size::ClampToNonNegative, prevent negative sizes always.

ui/gfx/size_base.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GFX_SIZE_BASE_H_
 #define UI_GFX_SIZE_BASE_H_
 
 #include <string>
 
 #include "base/compiler_specific.h"
@@ skipping 14 matching lines @@
   void SetSize(Type width, Type height) {
     set_width(width);
     set_height(height);
   }
 
   void Enlarge(Type width, Type height) {
     set_width(width_ + width);
     set_height(height_ + height);
   }
 
-  void set_width(Type width) { width_ = width; }
-  void set_height(Type height) { height_ = height; }
+  void set_width(Type width) { width_ = width < 0 ? 0 : width; }

[sky, 2012/11/09 17:03:55]

Where we previously doing this? I thought previously we let through negatives.

[danakj, 2012/11/09 17:06:57]

There were DCHECKs previously.

+  void set_height(Type height) { height_ = height < 0 ? 0 : height; }
 
   bool IsEmpty() const {
-    return (width_ <= 0) || (height_ <= 0);
-  }
-
-  void ClampToNonNegative() {
-    if (width_ < 0)
-      width_ = 0;
-    if (height_ < 0)
-      height_ = 0;
+    return (width_ == 0) || (height_ == 0);
   }
 
  protected:
   SizeBase(Type width, Type height)
-      : width_(width),
-        height_(height) {}
+      : width_(width < 0 ? 0 : width),
+        height_(height < 0 ? 0 : height) {}
 
   // Destructor is intentionally made non virtual and protected.
   // Do not make this public.
   ~SizeBase() {}
 
  private:
   Type width_;
   Type height_;
 };
 
 }  // namespace gfx
 
 #endif  // UI_GFX_SIZE_BASE_H_