chrome/browser/system_monitor/removable_device_notifications_chromeos.h - Issue 11365142: Small refactoring in DiskMountManager (event reporting; format method).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/system_monitor/removable_device_notifications_chromeos.h

Issue 11365142: Small refactoring in DiskMountManager (event reporting; format method). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/imageburner/burn_controller.cc ('k') | chrome/browser/system_monitor/removable_device_notifications_chromeos.cc » ('j') | chrome/browser/system_monitor/removable_device_notifications_chromeos.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/system_monitor/removable_device_notifications_chromeos.h

diff --git a/chrome/browser/system_monitor/removable_device_notifications_chromeos.h b/chrome/browser/system_monitor/removable_device_notifications_chromeos.h

index a767e8557441c152b02f05c7e4570256a34c4570..2b4506a40e7cc6d884371c834bd9d7d739af6db4 100644

--- a/chrome/browser/system_monitor/removable_device_notifications_chromeos.h

+++ b/chrome/browser/system_monitor/removable_device_notifications_chromeos.h

@@ -45,14 +45,18 @@ class RemovableDeviceNotificationsCros

static RemovableDeviceNotificationsCros* GetInstance();

- virtual void DiskChanged(disks::DiskMountManagerEventType event,

+ virtual void OnDiskEvent(disks::DiskMountManager::DiskEvent event,

const disks::DiskMountManager::Disk* disk) OVERRIDE;

- virtual void DeviceChanged(disks::DiskMountManagerEventType event,

+ virtual void OnDeviceEvent(disks::DiskMountManager::DeviceEvent event,

const std::string& device_path) OVERRIDE;

- virtual void MountCompleted(

- disks::DiskMountManager::MountEvent event_type,

+ virtual void OnMountEvent(

+ disks::DiskMountManager::MountEvent event,

MountError error_code,

const disks::DiskMountManager::MountPointInfo& mount_info) OVERRIDE;

+ virtual void OnFormatEvent(

+ disks::DiskMountManager::FormatEvent event,

+ FormatError error_code,

+ const std::string& device_path) OVERRIDE;

// Finds the device that contains |path| and populates |device_info|.

// Returns false if unable to find the device.