Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart

Issue 11365132: Fix the build: we must still not mangle parameter names of native methods. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart (revision 14626)
+++ sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart (working copy)
@@ -511,7 +511,13 @@
if (name != null) return addAllocatedName(instruction, name);
}
- if (instruction.sourceElement != null) {
+ // The dom/html libraries have inline JS code that reference
floitsch 2012/11/07 16:44:30 remove tab.
+ // parameter names directly. Long-term such code will be rejected.
+ // Now, just don't mangle the parameter name.
+ if (instruction is HParameterValue
+ && instruction.sourceElement.enclosingElement.isNative()) {
+ name = instruction.sourceElement.name.slowToString();
+ } else if (instruction.sourceElement != null) {
name = allocateWithHint(instruction.sourceElement.name.slowToString());
} else {
// We could not find an element for the instruction. If the
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698