Chromium Code Reviews| Index: media/filters/video_renderer_algorithm.h |
| diff --git a/media/filters/video_renderer_algorithm.h b/media/filters/video_renderer_algorithm.h |
| index 3c37e7f300f6bf79c3260a184357efa72032dc46..3d70c3fbe45e6f5bad397804f27128f60da39577 100644 |
| --- a/media/filters/video_renderer_algorithm.h |
| +++ b/media/filters/video_renderer_algorithm.h |
| @@ -44,10 +44,8 @@ namespace media { |
| // Combined these three approaches enforce optimal smoothness in many cases. |
| class MEDIA_EXPORT VideoRendererAlgorithm { |
| public: |
| - // Used to convert a media timestamp into wall clock time. |
| - using TimeConverterCB = base::Callback<base::TimeTicks(base::TimeDelta)>; |
| - |
| - explicit VideoRendererAlgorithm(const TimeConverterCB& time_converter_cb); |
| + explicit VideoRendererAlgorithm( |
| + const TimeSource::WallClockTimeCB& time_converter_cb); |
|
xhwang
2015/05/12 04:46:53
We are using WallClockTimeCB and wall_clock_time_c
DaleCurtis
2015/05/12 05:35:42
Done.
|
| ~VideoRendererAlgorithm(); |
| // Chooses the best frame for the interval [deadline_min, deadline_max] based |
| @@ -162,6 +160,10 @@ class MEDIA_EXPORT VideoRendererAlgorithm { |
| base::TimeTicks start_time; |
| base::TimeTicks end_time; |
| + // True if this frame's end time is based on the average frame duration and |
|
DaleCurtis
2015/05/12 01:32:34
This simplifies the code a bit and makes it easier
|
| + // not the time of the next frame. |
| + bool estimated_end_time; |
| + |
| int ideal_render_count; |
| int render_count; |
| int drop_count; |
| @@ -178,8 +180,8 @@ class MEDIA_EXPORT VideoRendererAlgorithm { |
| // calculate an average frame duration. Updates |cadence_estimator_|. |
| // |
| // Note: Wall clock time is recomputed each Render() call because it's |
| - // expected that the TimeSource powering TimeConverterCB will skew slightly |
| - // based on the audio clock. |
| + // expected that the TimeSource powering TimeSource::WallClockTimeCB will skew |
| + // slightly based on the audio clock. |
| // |
| // TODO(dalecurtis): Investigate how accurate we need the wall clock times to |
| // be, so we can avoid recomputing every time (we would need to recompute when |
| @@ -259,7 +261,7 @@ class MEDIA_EXPORT VideoRendererAlgorithm { |
| bool have_rendered_frames_; |
| // Callback used to convert media timestamps into wall clock timestamps. |
| - const TimeConverterCB time_converter_cb_; |
| + const TimeSource::WallClockTimeCB wall_clock_time_cb_; |
| // The last |deadline_max| provided to Render(), used to predict whether |
| // frames were rendered over cadence between Render() calls. |