Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: media/base/wall_clock_time_source.h

Issue 1136513004: Switch GetWallClockTime to using vectors for input and output. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use vector. Cleanup. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_BASE_WALL_CLOCK_TIME_SOURCE_H_ 5 #ifndef MEDIA_BASE_WALL_CLOCK_TIME_SOURCE_H_
6 #define MEDIA_BASE_WALL_CLOCK_TIME_SOURCE_H_ 6 #define MEDIA_BASE_WALL_CLOCK_TIME_SOURCE_H_
7 7
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "base/synchronization/lock.h" 9 #include "base/synchronization/lock.h"
10 #include "base/time/default_tick_clock.h"
10 #include "media/base/media_export.h" 11 #include "media/base/media_export.h"
11 #include "media/base/time_source.h" 12 #include "media/base/time_source.h"
12 13
13 namespace base {
14 class TickClock;
15 }
16
17 namespace media { 14 namespace media {
18 15
19 // A time source that uses interpolation based on the system clock. 16 // A time source that uses interpolation based on the system clock.
20 class MEDIA_EXPORT WallClockTimeSource : public TimeSource { 17 class MEDIA_EXPORT WallClockTimeSource : public TimeSource {
21 public: 18 public:
22 WallClockTimeSource(); 19 WallClockTimeSource();
23 ~WallClockTimeSource() override; 20 ~WallClockTimeSource() override;
24 21
25 // TimeSource implementation. 22 // TimeSource implementation.
26 void StartTicking() override; 23 void StartTicking() override;
27 void StopTicking() override; 24 void StopTicking() override;
28 void SetPlaybackRate(double playback_rate) override; 25 void SetPlaybackRate(double playback_rate) override;
29 void SetMediaTime(base::TimeDelta time) override; 26 void SetMediaTime(base::TimeDelta time) override;
30 base::TimeDelta CurrentMediaTime() override; 27 base::TimeDelta CurrentMediaTime() override;
31 base::TimeTicks GetWallClockTime(base::TimeDelta time) override; 28 bool GetWallClockTime(
29 const std::vector<base::TimeDelta>& media_timestamps,
30 std::vector<base::TimeTicks>* wall_clock_times) override;
32 31
33 void SetTickClockForTesting(scoped_ptr<base::TickClock> tick_clock); 32 void set_tick_clock_for_testing(base::TickClock* tick_clock) {
DaleCurtis 2015/05/12 01:32:34 Required for use in VideoRendererImpl unittest sin
33 tick_clock_ = tick_clock;
34 }
34 35
35 private: 36 private:
36 base::TimeDelta CurrentMediaTime_Locked(); 37 base::TimeDelta CurrentMediaTime_Locked();
37 38
38 scoped_ptr<base::TickClock> tick_clock_; 39 // Allow for an injectable tick clock for testing.
40 base::DefaultTickClock default_tick_clock_;
41
42 // If specified, used instead of |default_tick_clock_|.
43 base::TickClock* tick_clock_;
44
39 bool ticking_; 45 bool ticking_;
40 46
41 // While ticking we can interpolate the current media time by measuring the 47 // While ticking we can interpolate the current media time by measuring the
42 // delta between our reference ticks and the current system ticks and scaling 48 // delta between our reference ticks and the current system ticks and scaling
43 // that time by the playback rate. 49 // that time by the playback rate.
44 double playback_rate_; 50 double playback_rate_;
45 base::TimeDelta base_time_; 51 base::TimeDelta base_time_;
46 base::TimeTicks reference_wall_ticks_; 52 base::TimeTicks reference_wall_ticks_;
47 53
48 // TODO(scherkus): Remove internal locking from this class after access to 54 // TODO(scherkus): Remove internal locking from this class after access to
49 // Renderer::CurrentMediaTime() is single threaded http://crbug.com/370634 55 // Renderer::CurrentMediaTime() is single threaded http://crbug.com/370634
50 base::Lock lock_; 56 base::Lock lock_;
51 57
52 DISALLOW_COPY_AND_ASSIGN(WallClockTimeSource); 58 DISALLOW_COPY_AND_ASSIGN(WallClockTimeSource);
53 }; 59 };
54 60
55 } // namespace media 61 } // namespace media
56 62
57 #endif // MEDIA_BASE_WALL_CLOCK_TIME_SOURCE_H_ 63 #endif // MEDIA_BASE_WALL_CLOCK_TIME_SOURCE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698