Switch GetWallClockTime to using vectors for input and output.

media/renderers/audio_renderer_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/renderers/audio_renderer_impl.h"
 
 #include <math.h>
 
 #include <algorithm>
 
@@ skipping 148 matching lines @@
   base::TimeDelta current_media_time;
   {
     base::AutoLock auto_lock(lock_);
     current_media_time = audio_clock_->front_timestamp();
   }
 
   DVLOG(2) << __FUNCTION__ << ": " << current_media_time;
   return current_media_time;
 }
 
-base::TimeTicks AudioRendererImpl::GetWallClockTime(base::TimeDelta time) {
+bool AudioRendererImpl::GetWallClockTime(
+    const std::vector<base::TimeDelta>& media_timestamps,
+    std::vector<base::TimeTicks>* wall_clock_times) {
   base::AutoLock auto_lock(lock_);
-  if (last_render_ticks_.is_null() || playback_rate_ == 0.0)
-    return base::TimeTicks();
+  if (last_render_ticks_.is_null() || !playback_rate_)
+    return false;
 
-  base::TimeDelta base_time;
-  if (time < audio_clock_->front_timestamp()) {
-    // See notes about |time| values less than |base_time| in TimeSource header.
-    base_time = audio_clock_->front_timestamp();
-  } else if (time > audio_clock_->back_timestamp()) {
-    base_time = audio_clock_->back_timestamp();
-  } else {
-    // No need to estimate time, so return the actual wallclock time.
-    return last_render_ticks_ + audio_clock_->TimeUntilPlayback(time);
+  DCHECK(wall_clock_times->empty());
+  wall_clock_times->reserve(media_timestamps.size());
+  for (const auto& media_timestamp : media_timestamps) {
+    base::TimeDelta base_time;
+    if (media_timestamp < audio_clock_->front_timestamp()) {
+      // See notes about |media_time| values less than |base_time| in TimeSource
+      // header.
+      base_time = audio_clock_->front_timestamp();
+    } else if (media_timestamp > audio_clock_->back_timestamp()) {
+      base_time = audio_clock_->back_timestamp();
+    } else {
+      // No need to estimate time, so return the actual wallclock time.
+      wall_clock_times->push_back(
+          last_render_ticks_ +
+          audio_clock_->TimeUntilPlayback(media_timestamp));

[xhwang, 2015/05/12 04:46:53]

nit: will base_time = media_timestamp work? Or are you worried about
performance?

[DaleCurtis, 2015/05/12 05:35:42]

It would, but I felt it was misleading to have the playback rate calculation
used in this case since there may be multiple playback rates within the
AudioClock bounds.

+      continue;
+    }
+
+    // In practice, most calls will be estimates given the relatively small
+    // window in which clients can get the actual time.
+    wall_clock_times->push_back(
+        last_render_ticks_ + audio_clock_->TimeUntilPlayback(base_time) +
+        base::TimeDelta::FromMicroseconds(
+            (media_timestamp - base_time).InMicroseconds() / playback_rate_));
   }
-
-  // In practice, most calls will be estimates given the relatively small window
-  // in which clients can get the actual time.
-  return last_render_ticks_ + audio_clock_->TimeUntilPlayback(base_time) +
-         base::TimeDelta::FromMicroseconds((time - base_time).InMicroseconds() /
-                                           playback_rate_);
+  return true;
 }
 
 TimeSource* AudioRendererImpl::GetTimeSource() {
   return this;
 }
 
 void AudioRendererImpl::Flush(const base::Closure& callback) {
   DVLOG(1) << __FUNCTION__;
   DCHECK(task_runner_->BelongsToCurrentThread());
 
@@ skipping 550 matching lines @@
            << buffering_state;
   DCHECK_NE(buffering_state_, buffering_state);
   lock_.AssertAcquired();
   buffering_state_ = buffering_state;
 
   task_runner_->PostTask(FROM_HERE,
                          base::Bind(buffering_state_cb_, buffering_state_));
 }
 
 }  // namespace media