Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: LayoutTests/http/tests/push_messaging/permission-state-exception-in-document.html

Issue 1136513002: Reject permissonState calls if userVisible is not present as parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/http/tests/push_messaging/permission-state-denied-in-service-worker.html ('k') | LayoutTests/http/tests/push_messaging/permission-state-exception-in-service-worker.html » ('j') | Source/modules/push_messaging/PushManager.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <html> 2 <html>
3 <head> 3 <head>
4 <title>Push API: permissionState resolves with prompt when no permission is set< /title> 4 <title>Push API: permissionState fails with NotSupportedError if userVisibleOnly is not used</title>
5 <link rel="manifest" href="resources/push_manifest.json"> 5 <link rel="manifest" href="resources/push_manifest.json">
6 <script src="../resources/testharness.js"></script> 6 <script src="../resources/testharness.js"></script>
7 <script src="../resources/testharnessreport.js"></script> 7 <script src="../resources/testharnessreport.js"></script>
8 <script src="../serviceworker/resources/test-helpers.js"></script> 8 <script src="../serviceworker/resources/test-helpers.js"></script>
9 </head> 9 </head>
10 <body> 10 <body>
11 <script> 11 <script>
12 async_test(function(test) { 12 async_test(function(test) {
13 if (window.testRunner) 13 if (window.testRunner)
14 testRunner.setPermission('push-messaging', 'prompt', location.origin, lo cation.origin); 14 testRunner.setPermission('push-messaging', 'prompt', location.origin, lo cation.origin);
15 15
16 var workerUrl = 'resources/empty_worker.js'; 16 var workerUrl = 'resources/empty_worker.js';
17 var workerScope = 'resources/scope/' + location.pathname; 17 var workerScope = 'resources/scope/' + location.pathname;
18 service_worker_unregister_and_register(test, workerUrl, workerScope) 18 service_worker_unregister_and_register(test, workerUrl, workerScope)
19 .then(function(serviceWorkerRegistration) { 19 .then(function(serviceWorkerRegistration) {
20 // If running manually, clear permissions before running this test. 20 // If running manually, clear permissions before running this test.
21 return serviceWorkerRegistration.pushManager.permissionState(); 21 return serviceWorkerRegistration.pushManager.permissionState();
22 }) 22 })
23 .then(function(permissionStatus) { 23 .then(function(permissionStatus) {
24 assert_equals(permissionStatus, 'prompt'); 24 assert_unreached('permissionStatus should have failed with a NotSupp orted exception');
25 return service_worker_unregister_and_done(test, workerScope); 25 }, function(error) {
26 }) 26 assert_equals(error.name, 'NotSupportedError');
27 .catch(unreached_rejection(test)); 27 assert_equals(error.message,
28 }, 'Push API: permissionState() resolves with prompt when permission is not set' ); 28 'Chrome does not support push subscriptions that do no t enable the userVisibleOnly option.');
29 test.done();
30 }).catch(unreached_rejection(test));
31 }, 'Push API: permissionState fails with NotSupportedError if userVisibleOnly is not used');
29 </script> 32 </script>
30 </body> 33 </body>
31 </html> 34 </html>
OLDNEW
« no previous file with comments | « LayoutTests/http/tests/push_messaging/permission-state-denied-in-service-worker.html ('k') | LayoutTests/http/tests/push_messaging/permission-state-exception-in-service-worker.html » ('j') | Source/modules/push_messaging/PushManager.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698