Reject permissonState calls if userVisible is not present as parameter

Source/modules/push_messaging/PushManager.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/push_messaging/PushManager.h"
 
 #include "bindings/core/v8/CallbackPromiseAdapter.h"
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
@@ skipping 75 matching lines @@
 }
 
 ScriptPromise PushManager::permissionState(ScriptState* scriptState, const PushSubscriptionOptions& options)
 {
     if (scriptState->executionContext()->isDocument()) {
         Document* document = toDocument(scriptState->executionContext());
         // FIXME: add test coverage for this condition - https://crbug.com/440431
         if (!document->domWindow() || !document->frame())
             return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(InvalidStateError, "Document is detached from window."));
     }
+    if (!options.userVisibleOnly()) {
+        return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(NotSupportedError, "non-visible push messages are not supported."));

[Peter Beverloo, 2015/05/07 15:28:21]

What about: "Chrome does not yet support push subscriptions that do not enable
the userVisibleOnly option."

This (a) indicates that it's Chrome-specific behavior, not per the spec, and (b)
refers to the userVisibleOnly option, which is a term for developers to work
towards enabling this.

[Miguel Garcia, 2015/05/07 19:40:46]

I'd prefer to avoid "yet" since it's not clear exactly what's our timeline and
conditions for silent push.

I will go with "Chrome does not support push subscriptions that do not enable
the userVisibleOnly option."


On 2015/05/07 15:28:21, Peter Beverloo wrote:

+    }
 
     RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
     ScriptPromise promise = resolver->promise();
 
     pushProvider()->getPermissionStatus(m_registration->webRegistration(), toWebPushSubscriptionOptions(options), new PushPermissionStatusCallbacks(resolver));
     return promise;
 }
 
 DEFINE_TRACE(PushManager)
 {
     visitor->trace(m_registration);
 }
 
 } // namespace blink