Change PrefStore::ReadResult to a boolean.

chrome/browser/policy/configuration_policy_pref_store_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/file_path.h"
 #include "base/memory/ref_counted.h"
 #include "base/prefs/pref_store_observer_mock.h"
 #include "chrome/browser/policy/configuration_policy_handler.h"
@@ skipping 51 matching lines @@
   scoped_ptr<PolicyServiceImpl> policy_service_;
   scoped_refptr<ConfigurationPolicyPrefStore> store_;
 };
 
 // Test cases for list-valued policy settings.
 class ConfigurationPolicyPrefStoreListTest
     : public ConfigurationPolicyPrefStoreTest,
       public testing::WithParamInterface<PolicyAndPref> {};
 
 TEST_P(ConfigurationPolicyPrefStoreListTest, GetDefault) {
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(GetParam().pref_name(), NULL));
+  EXPECT_FALSE(store_->GetValue(GetParam().pref_name(), NULL));
 }
 
 TEST_P(ConfigurationPolicyPrefStoreListTest, SetValue) {
   base::ListValue* in_value = new base::ListValue();
   in_value->Append(base::Value::CreateStringValue("test1"));
   in_value->Append(base::Value::CreateStringValue("test2,"));
   PolicyMap policy;
   policy.Set(GetParam().policy_name(), POLICY_LEVEL_MANDATORY,
              POLICY_SCOPE_USER, in_value);
   provider_.UpdateChromePolicy(policy);
   const base::Value* value = NULL;
-  EXPECT_EQ(PrefStore::READ_OK,
-            store_->GetValue(GetParam().pref_name(), &value));
+  EXPECT_TRUE(store_->GetValue(GetParam().pref_name(), &value));
   ASSERT_TRUE(value);
   EXPECT_TRUE(in_value->Equals(value));
 }
 
 INSTANTIATE_TEST_CASE_P(
     ConfigurationPolicyPrefStoreListTestInstance,
     ConfigurationPolicyPrefStoreListTest,
     testing::Values(
         PolicyAndPref(key::kRestoreOnStartupURLs,
                       prefs::kURLsToRestoreOnStartup),
@@ skipping 11 matching lines @@
                       prefs::kUrlBlacklist),
         PolicyAndPref(key::kURLWhitelist,
                       prefs::kUrlWhitelist)));
 
 // Test cases for string-valued policy settings.
 class ConfigurationPolicyPrefStoreStringTest
     : public ConfigurationPolicyPrefStoreTest,
       public testing::WithParamInterface<PolicyAndPref> {};
 
 TEST_P(ConfigurationPolicyPrefStoreStringTest, GetDefault) {
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(GetParam().pref_name(), NULL));
+  EXPECT_FALSE(store_->GetValue(GetParam().pref_name(), NULL));
 }
 
 TEST_P(ConfigurationPolicyPrefStoreStringTest, SetValue) {
   PolicyMap policy;
   policy.Set(GetParam().policy_name(), POLICY_LEVEL_MANDATORY,
              POLICY_SCOPE_USER,
              base::Value::CreateStringValue("http://chromium.org"));
   provider_.UpdateChromePolicy(policy);
   const base::Value* value = NULL;
-  EXPECT_EQ(PrefStore::READ_OK,
-            store_->GetValue(GetParam().pref_name(), &value));
+  EXPECT_TRUE(store_->GetValue(GetParam().pref_name(), &value));
   ASSERT_TRUE(value);
   EXPECT_TRUE(base::StringValue("http://chromium.org").Equals(value));
 }
 
 INSTANTIATE_TEST_CASE_P(
     ConfigurationPolicyPrefStoreStringTestInstance,
     ConfigurationPolicyPrefStoreStringTest,
     testing::Values(
         PolicyAndPref(key::kRestrictSigninToPattern,
                       prefs::kGoogleServicesUsernamePattern),
@@ skipping 19 matching lines @@
     testing::Values(PolicyAndPref(key::kDownloadDirectory,
                                   prefs::kDownloadDefaultDirectory)));
 #endif  // !defined(OS_CHROMEOS)
 
 // Test cases for boolean-valued policy settings.
 class ConfigurationPolicyPrefStoreBooleanTest
     : public ConfigurationPolicyPrefStoreTest,
       public testing::WithParamInterface<PolicyAndPref> {};
 
 TEST_P(ConfigurationPolicyPrefStoreBooleanTest, GetDefault) {
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(GetParam().pref_name(), NULL));
+  EXPECT_FALSE(store_->GetValue(GetParam().pref_name(), NULL));
 }
 
 TEST_P(ConfigurationPolicyPrefStoreBooleanTest, SetValue) {
   PolicyMap policy;
   policy.Set(GetParam().policy_name(), POLICY_LEVEL_MANDATORY,
              POLICY_SCOPE_USER, base::Value::CreateBooleanValue(false));
   provider_.UpdateChromePolicy(policy);
   const base::Value* value = NULL;
-  EXPECT_EQ(PrefStore::READ_OK,
-            store_->GetValue(GetParam().pref_name(), &value));
+  EXPECT_TRUE(store_->GetValue(GetParam().pref_name(), &value));
   ASSERT_TRUE(value);
   bool boolean_value = true;
   bool result = value->GetAsBoolean(&boolean_value);
   ASSERT_TRUE(result);
   EXPECT_FALSE(boolean_value);
 
   policy.Set(GetParam().policy_name(), POLICY_LEVEL_MANDATORY,
              POLICY_SCOPE_USER, base::Value::CreateBooleanValue(true));
   provider_.UpdateChromePolicy(policy);
   value = NULL;
-  EXPECT_EQ(PrefStore::READ_OK,
-            store_->GetValue(GetParam().pref_name(), &value));
+  EXPECT_TRUE(store_->GetValue(GetParam().pref_name(), &value));
   boolean_value = false;
   result = value->GetAsBoolean(&boolean_value);
   ASSERT_TRUE(result);
   EXPECT_TRUE(boolean_value);
 }
 
 INSTANTIATE_TEST_CASE_P(
     ConfigurationPolicyPrefStoreBooleanTestInstance,
     ConfigurationPolicyPrefStoreBooleanTest,
     testing::Values(
@@ skipping 94 matching lines @@
         PolicyAndPref(key::kAudioCaptureAllowed,
                       prefs::kAudioCaptureAllowed)));
 #endif  // defined(OS_CHROMEOS)
 
 // Test cases for integer-valued policy settings.
 class ConfigurationPolicyPrefStoreIntegerTest
     : public ConfigurationPolicyPrefStoreTest,
       public testing::WithParamInterface<PolicyAndPref> {};
 
 TEST_P(ConfigurationPolicyPrefStoreIntegerTest, GetDefault) {
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(GetParam().pref_name(), NULL));
+  EXPECT_FALSE(store_->GetValue(GetParam().pref_name(), NULL));
 }
 
 TEST_P(ConfigurationPolicyPrefStoreIntegerTest, SetValue) {
   PolicyMap policy;
   policy.Set(GetParam().policy_name(), POLICY_LEVEL_MANDATORY,
              POLICY_SCOPE_USER, base::Value::CreateIntegerValue(2));
   provider_.UpdateChromePolicy(policy);
   const base::Value* value = NULL;
-  EXPECT_EQ(PrefStore::READ_OK,
-            store_->GetValue(GetParam().pref_name(), &value));
+  EXPECT_TRUE(store_->GetValue(GetParam().pref_name(), &value));
   EXPECT_TRUE(base::FundamentalValue(2).Equals(value));
 }
 
 INSTANTIATE_TEST_CASE_P(
     ConfigurationPolicyPrefStoreIntegerTestInstance,
     ConfigurationPolicyPrefStoreIntegerTest,
     testing::Values(
         PolicyAndPref(key::kDefaultCookiesSetting,
                       prefs::kManagedDefaultCookiesSetting),
         PolicyAndPref(key::kDefaultImagesSetting,
@@ skipping 21 matching lines @@
 class ConfigurationPolicyPrefStoreProxyTest
     : public ConfigurationPolicyPrefStoreTest {
  protected:
   // Verify that all the proxy prefs are set to the specified expected values.
   void VerifyProxyPrefs(
       const std::string& expected_proxy_server,
       const std::string& expected_proxy_pac_url,
       const std::string& expected_proxy_bypass_list,
       const ProxyPrefs::ProxyMode& expected_proxy_mode) {
     const base::Value* value = NULL;
-    ASSERT_EQ(PrefStore::READ_OK,
-              store_->GetValue(prefs::kProxy, &value));
+    ASSERT_TRUE(store_->GetValue(prefs::kProxy, &value));
     ASSERT_EQ(base::Value::TYPE_DICTIONARY, value->GetType());
     ProxyConfigDictionary dict(
         static_cast<const base::DictionaryValue*>(value));
     std::string s;
     if (expected_proxy_server.empty()) {
       EXPECT_FALSE(dict.GetProxyServer(&s));
     } else {
       ASSERT_TRUE(dict.GetProxyServer(&s));
       EXPECT_EQ(expected_proxy_server, s);
     }
@@ skipping 51 matching lines @@
 
 TEST_F(ConfigurationPolicyPrefStoreProxyTest, ManualOptionsInvalid) {
   PolicyMap policy;
   policy.Set(
       key::kProxyServerMode, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
       base::Value::CreateIntegerValue(
           ProxyPolicyHandler::PROXY_MANUALLY_CONFIGURED_PROXY_SERVER_MODE));
   provider_.UpdateChromePolicy(policy);
 
   const base::Value* value = NULL;
-  EXPECT_EQ(PrefStore::READ_NO_VALUE, store_->GetValue(prefs::kProxy, &value));
+  EXPECT_FALSE(store_->GetValue(prefs::kProxy, &value));
 }
 
 
 TEST_F(ConfigurationPolicyPrefStoreProxyTest, NoProxyServerMode) {
   PolicyMap policy;
   policy.Set(key::kProxyServerMode, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
              base::Value::CreateIntegerValue(
                  ProxyPolicyHandler::PROXY_SERVER_MODE));
   provider_.UpdateChromePolicy(policy);
   VerifyProxyPrefs("", "", "", ProxyPrefs::MODE_DIRECT);
@@ skipping 38 matching lines @@
                    ProxyPrefs::MODE_PAC_SCRIPT);
 }
 
 TEST_F(ConfigurationPolicyPrefStoreProxyTest, PacScriptProxyModeInvalid) {
   PolicyMap policy;
   policy.Set(key::kProxyMode, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
              base::Value::CreateStringValue(
                  ProxyPrefs::kPacScriptProxyModeName));
   provider_.UpdateChromePolicy(policy);
   const base::Value* value = NULL;
-  EXPECT_EQ(PrefStore::READ_NO_VALUE, store_->GetValue(prefs::kProxy, &value));
+  EXPECT_FALSE(store_->GetValue(prefs::kProxy, &value));
 }
 
 // Regression test for http://crbug.com/78016, CPanel returns empty strings
 // for unset properties.
 TEST_F(ConfigurationPolicyPrefStoreProxyTest, PacScriptProxyModeBug78016) {
   PolicyMap policy;
   policy.Set(key::kProxyServer, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
              base::Value::CreateStringValue(""));
   policy.Set(key::kProxyPacUrl, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
              base::Value::CreateStringValue("http://short.org/proxy.pac"));
@@ skipping 42 matching lines @@
              base::Value::CreateStringValue("http://short.org/proxy.pac"));
   policy.Set(key::kProxyBypassList, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
              base::Value::CreateStringValue("http://chromium.org/override"));
   policy.Set(key::kProxyServer, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
              base::Value::CreateStringValue("chromium.org"));
   for (int i = 0; i < ProxyPolicyHandler::MODE_COUNT; ++i) {
     policy.Set(key::kProxyServerMode, POLICY_LEVEL_MANDATORY,
                POLICY_SCOPE_USER, base::Value::CreateIntegerValue(i));
     provider_.UpdateChromePolicy(policy);
     const base::Value* value = NULL;
-    EXPECT_EQ(PrefStore::READ_NO_VALUE,
-              store_->GetValue(prefs::kProxy, &value));
+    EXPECT_FALSE(store_->GetValue(prefs::kProxy, &value));
   }
 }
 
 class ConfigurationPolicyPrefStoreDefaultSearchTest
     : public ConfigurationPolicyPrefStoreTest {
  public:
   ConfigurationPolicyPrefStoreDefaultSearchTest() {
     default_alternate_urls_.AppendString(
         "http://www.google.com/#q={searchTerms}");
     default_alternate_urls_.AppendString(
@@ skipping 53 matching lines @@
 // search URL, that all the elements have been given proper defaults.
 TEST_F(ConfigurationPolicyPrefStoreDefaultSearchTest, MinimallyDefined) {
   PolicyMap policy;
   policy.Set(key::kDefaultSearchProviderEnabled, POLICY_LEVEL_MANDATORY,
              POLICY_SCOPE_USER, base::Value::CreateBooleanValue(true));
   policy.Set(key::kDefaultSearchProviderSearchURL, POLICY_LEVEL_MANDATORY,
              POLICY_SCOPE_USER, base::Value::CreateStringValue(kSearchURL));
   provider_.UpdateChromePolicy(policy);
 
   const base::Value* value = NULL;
-  EXPECT_EQ(PrefStore::READ_OK,
-            store_->GetValue(prefs::kDefaultSearchProviderSearchURL, &value));
+  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderSearchURL, &value));
   EXPECT_TRUE(base::StringValue(kSearchURL).Equals(value));
 
-  EXPECT_EQ(PrefStore::READ_OK,
-            store_->GetValue(prefs::kDefaultSearchProviderName, &value));
+  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderName, &value));
   EXPECT_TRUE(base::StringValue("test.com").Equals(value));
 
-  EXPECT_EQ(PrefStore::READ_OK,
-            store_->GetValue(prefs::kDefaultSearchProviderKeyword, &value));
+  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderKeyword, &value));
   EXPECT_TRUE(base::StringValue("test.com").Equals(value));
 
-  EXPECT_EQ(PrefStore::READ_OK,
-            store_->GetValue(prefs::kDefaultSearchProviderSuggestURL, &value));
+  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderSuggestURL,
+                               &value));
   EXPECT_TRUE(base::StringValue(std::string()).Equals(value));
 
-  EXPECT_EQ(PrefStore::READ_OK,
-            store_->GetValue(prefs::kDefaultSearchProviderIconURL, &value));
+  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderIconURL, &value));
   EXPECT_TRUE(base::StringValue(std::string()).Equals(value));
 
-  EXPECT_EQ(PrefStore::READ_OK,
-            store_->GetValue(prefs::kDefaultSearchProviderEncodings, &value));
+  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderEncodings, &value));
   EXPECT_TRUE(base::StringValue(std::string()).Equals(value));
 
-  EXPECT_EQ(PrefStore::READ_OK,
-            store_->GetValue(prefs::kDefaultSearchProviderInstantURL, &value));
+  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderInstantURL,
+                               &value));
   EXPECT_TRUE(base::StringValue(std::string()).Equals(value));
 
-  EXPECT_EQ(PrefStore::READ_OK,
-            store_->GetValue(prefs::kDefaultSearchProviderAlternateURLs,
+  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderAlternateURLs,
                              &value));
   EXPECT_TRUE(base::ListValue().Equals(value));
 }
 
 // Checks that for a fully defined search policy, all elements have been
 // read properly.
 TEST_F(ConfigurationPolicyPrefStoreDefaultSearchTest, FullyDefined) {
   PolicyMap policy;
   BuildDefaultSearchPolicy(&policy);
   provider_.UpdateChromePolicy(policy);
 
   const base::Value* value = NULL;
-  EXPECT_EQ(PrefStore::READ_OK,
-            store_->GetValue(prefs::kDefaultSearchProviderSearchURL, &value));
+  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderSearchURL, &value));
   EXPECT_TRUE(base::StringValue(kSearchURL).Equals(value));
 
-  EXPECT_EQ(PrefStore::READ_OK,
-            store_->GetValue(prefs::kDefaultSearchProviderName, &value));
+  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderName, &value));
   EXPECT_TRUE(base::StringValue(kName).Equals(value));
 
-  EXPECT_EQ(PrefStore::READ_OK,
-            store_->GetValue(prefs::kDefaultSearchProviderKeyword, &value));
+  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderKeyword, &value));
   EXPECT_TRUE(base::StringValue(kKeyword).Equals(value));
 
-  EXPECT_EQ(PrefStore::READ_OK,
-            store_->GetValue(prefs::kDefaultSearchProviderSuggestURL, &value));
+  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderSuggestURL,
+                               &value));
   EXPECT_TRUE(base::StringValue(kSuggestURL).Equals(value));
 
-  EXPECT_EQ(PrefStore::READ_OK,
-            store_->GetValue(prefs::kDefaultSearchProviderIconURL, &value));
+  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderIconURL, &value));
   EXPECT_TRUE(base::StringValue(kIconURL).Equals(value));
 
-  EXPECT_EQ(PrefStore::READ_OK,
-            store_->GetValue(prefs::kDefaultSearchProviderEncodings, &value));
+  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderEncodings, &value));
   EXPECT_TRUE(base::StringValue("UTF-16;UTF-8").Equals(value));
 
-  EXPECT_EQ(PrefStore::READ_OK, store_->GetValue(
+  EXPECT_TRUE(store_->GetValue(
       prefs::kDefaultSearchProviderAlternateURLs, &value));
   EXPECT_TRUE(default_alternate_urls_.Equals(value));
 }
 
 // Checks that if the default search policy is missing, that no elements of the
 // default search policy will be present.
 TEST_F(ConfigurationPolicyPrefStoreDefaultSearchTest, MissingUrl) {
   PolicyMap policy;
   BuildDefaultSearchPolicy(&policy);
   policy.Erase(key::kDefaultSearchProviderSearchURL);
   provider_.UpdateChromePolicy(policy);
 
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(prefs::kDefaultSearchProviderSearchURL, NULL));
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(prefs::kDefaultSearchProviderName, NULL));
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(prefs::kDefaultSearchProviderKeyword, NULL));
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(prefs::kDefaultSearchProviderSuggestURL, NULL));
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(prefs::kDefaultSearchProviderIconURL, NULL));
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(prefs::kDefaultSearchProviderEncodings, NULL));
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(prefs::kDefaultSearchProviderAlternateURLs, NULL));
+  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderSearchURL, NULL));
+  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderName, NULL));
+  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderKeyword, NULL));
+  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderSuggestURL, NULL));
+  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderIconURL, NULL));
+  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderEncodings, NULL));
+  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderAlternateURLs,
+                                NULL));
 }
 
 // Checks that if the default search policy is invalid, that no elements of the
 // default search policy will be present.
 TEST_F(ConfigurationPolicyPrefStoreDefaultSearchTest, Invalid) {
   PolicyMap policy;
   BuildDefaultSearchPolicy(&policy);
   const char* const bad_search_url = "http://test.com/noSearchTerms";
   policy.Set(key::kDefaultSearchProviderSearchURL, POLICY_LEVEL_MANDATORY,
              POLICY_SCOPE_USER,
              base::Value::CreateStringValue(bad_search_url));
   provider_.UpdateChromePolicy(policy);
 
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(prefs::kDefaultSearchProviderSearchURL, NULL));
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(prefs::kDefaultSearchProviderName, NULL));
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(prefs::kDefaultSearchProviderKeyword, NULL));
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(prefs::kDefaultSearchProviderSuggestURL, NULL));
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(prefs::kDefaultSearchProviderIconURL, NULL));
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(prefs::kDefaultSearchProviderEncodings, NULL));
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(prefs::kDefaultSearchProviderAlternateURLs, NULL));
+  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderSearchURL, NULL));
+  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderName, NULL));
+  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderKeyword, NULL));
+  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderSuggestURL, NULL));
+  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderIconURL, NULL));
+  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderEncodings, NULL));
+  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderAlternateURLs,
+                                NULL));
 }
 
 // Checks that if the default search policy is invalid, that no elements of the
 // default search policy will be present.
 TEST_F(ConfigurationPolicyPrefStoreDefaultSearchTest, Disabled) {
   PolicyMap policy;
   policy.Set(key::kDefaultSearchProviderEnabled, POLICY_LEVEL_MANDATORY,
              POLICY_SCOPE_USER, base::Value::CreateBooleanValue(false));
   provider_.UpdateChromePolicy(policy);
 
   const base::Value* value = NULL;
-  EXPECT_EQ(PrefStore::READ_OK,
-            store_->GetValue(prefs::kDefaultSearchProviderEnabled, &value));
+  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderEnabled, &value));
   base::FundamentalValue expected_enabled(false);
   EXPECT_TRUE(base::Value::Equals(&expected_enabled, value));
-  EXPECT_EQ(PrefStore::READ_OK,
-            store_->GetValue(prefs::kDefaultSearchProviderSearchURL, &value));
+  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderSearchURL, &value));
   base::StringValue expected_search_url("");
   EXPECT_TRUE(base::Value::Equals(&expected_search_url, value));
 }
 
 // Tests Incognito mode availability preference setting.
 class ConfigurationPolicyPrefStoreIncognitoModeTest
     : public ConfigurationPolicyPrefStoreTest {
  protected:
   static const int kIncognitoModeAvailabilityNotSet = -1;
 
@@ skipping 15 matching lines @@
     if (availability >= 0) {
       policy.Set(key::kIncognitoModeAvailability, POLICY_LEVEL_MANDATORY,
                  POLICY_SCOPE_USER,
                  base::Value::CreateIntegerValue(availability));
     }
     provider_.UpdateChromePolicy(policy);
   }
 
   void VerifyValues(IncognitoModePrefs::Availability availability) {
     const base::Value* value = NULL;
-    EXPECT_EQ(PrefStore::READ_OK,
-              store_->GetValue(prefs::kIncognitoModeAvailability, &value));
+    EXPECT_TRUE(store_->GetValue(prefs::kIncognitoModeAvailability, &value));
     EXPECT_TRUE(base::FundamentalValue(availability).Equals(value));
   }
 };
 
 // The following testcases verify that if the obsolete IncognitoEnabled
 // policy is not set, the IncognitoModeAvailability values should be copied
 // from IncognitoModeAvailability policy to pref "as is".
 TEST_F(ConfigurationPolicyPrefStoreIncognitoModeTest,
        NoObsoletePolicyAndIncognitoEnabled) {
   SetPolicies(INCOGNITO_ENABLED_UNKNOWN, IncognitoModePrefs::ENABLED);
   VerifyValues(IncognitoModePrefs::ENABLED);
 }
 
 TEST_F(ConfigurationPolicyPrefStoreIncognitoModeTest,
        NoObsoletePolicyAndIncognitoDisabled) {
   SetPolicies(INCOGNITO_ENABLED_UNKNOWN, IncognitoModePrefs::DISABLED);
   VerifyValues(IncognitoModePrefs::DISABLED);
 }
 
 TEST_F(ConfigurationPolicyPrefStoreIncognitoModeTest,
        NoObsoletePolicyAndIncognitoForced) {
   SetPolicies(INCOGNITO_ENABLED_UNKNOWN, IncognitoModePrefs::FORCED);
   VerifyValues(IncognitoModePrefs::FORCED);
 }
 
 TEST_F(ConfigurationPolicyPrefStoreIncognitoModeTest,
        NoObsoletePolicyAndNoIncognitoAvailability) {
   SetPolicies(INCOGNITO_ENABLED_UNKNOWN, kIncognitoModeAvailabilityNotSet);
   const base::Value* value = NULL;
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(prefs::kIncognitoModeAvailability, &value));
+  EXPECT_FALSE(store_->GetValue(prefs::kIncognitoModeAvailability, &value));
 }
 
 // Checks that if the obsolete IncognitoEnabled policy is set, if sets
 // the IncognitoModeAvailability preference only in case
 // the IncognitoModeAvailability policy is not specified.
 TEST_F(ConfigurationPolicyPrefStoreIncognitoModeTest,
        ObsoletePolicyDoesNotAffectAvailabilityEnabled) {
   SetPolicies(INCOGNITO_ENABLED_FALSE, IncognitoModePrefs::ENABLED);
   VerifyValues(IncognitoModePrefs::ENABLED);
 }
@@ skipping 14 matching lines @@
        ObsoletePolicySetsPreferenceToDisabled) {
   SetPolicies(INCOGNITO_ENABLED_FALSE, kIncognitoModeAvailabilityNotSet);
   VerifyValues(IncognitoModePrefs::DISABLED);
 }
 
 // Test cases for the Sync policy setting.
 class ConfigurationPolicyPrefStoreSyncTest
     : public ConfigurationPolicyPrefStoreTest {};
 
 TEST_F(ConfigurationPolicyPrefStoreSyncTest, Default) {
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(prefs::kSyncManaged, NULL));
+  EXPECT_FALSE(store_->GetValue(prefs::kSyncManaged, NULL));
 }
 
 TEST_F(ConfigurationPolicyPrefStoreSyncTest, Enabled) {
   PolicyMap policy;
   policy.Set(key::kSyncDisabled, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
              base::Value::CreateBooleanValue(false));
   provider_.UpdateChromePolicy(policy);
   // Enabling Sync should not set the pref.
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(prefs::kSyncManaged, NULL));
+  EXPECT_FALSE(store_->GetValue(prefs::kSyncManaged, NULL));
 }
 
 TEST_F(ConfigurationPolicyPrefStoreSyncTest, Disabled) {
   PolicyMap policy;
   policy.Set(key::kSyncDisabled, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
              base::Value::CreateBooleanValue(true));
   provider_.UpdateChromePolicy(policy);
   // Sync should be flagged as managed.
   const base::Value* value = NULL;
-  EXPECT_EQ(PrefStore::READ_OK, store_->GetValue(prefs::kSyncManaged, &value));
+  EXPECT_TRUE(store_->GetValue(prefs::kSyncManaged, &value));
   ASSERT_TRUE(value);
   bool sync_managed = false;
   bool result = value->GetAsBoolean(&sync_managed);
   ASSERT_TRUE(result);
   EXPECT_TRUE(sync_managed);
 }
 
 // Test cases for how the DownloadDirectory and AllowFileSelectionDialogs policy
 // influence the PromptForDownload preference.
 class ConfigurationPolicyPrefStorePromptDownloadTest
     : public ConfigurationPolicyPrefStoreTest {};
 
 TEST_F(ConfigurationPolicyPrefStorePromptDownloadTest, Default) {
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(prefs::kPromptForDownload, NULL));
+  EXPECT_FALSE(store_->GetValue(prefs::kPromptForDownload, NULL));
 }
 
 #if !defined(OS_CHROMEOS)
 TEST_F(ConfigurationPolicyPrefStorePromptDownloadTest, SetDownloadDirectory) {
   PolicyMap policy;
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(prefs::kPromptForDownload, NULL));
+  EXPECT_FALSE(store_->GetValue(prefs::kPromptForDownload, NULL));
   policy.Set(key::kDownloadDirectory, POLICY_LEVEL_MANDATORY,
              POLICY_SCOPE_USER, base::Value::CreateStringValue(""));
   provider_.UpdateChromePolicy(policy);
 
   // Setting a DownloadDirectory should disable the PromptForDownload pref.
   const base::Value* value = NULL;
-  EXPECT_EQ(PrefStore::READ_OK, store_->GetValue(prefs::kPromptForDownload,
+  EXPECT_TRUE(store_->GetValue(prefs::kPromptForDownload,
                                                  &value));
   ASSERT_TRUE(value);
   bool prompt_for_download = true;
   bool result = value->GetAsBoolean(&prompt_for_download);
   ASSERT_TRUE(result);
   EXPECT_FALSE(prompt_for_download);
 }
 #endif  // !defined(OS_CHROMEOS)
 
 TEST_F(ConfigurationPolicyPrefStorePromptDownloadTest,
        EnableFileSelectionDialogs) {
   PolicyMap policy;
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(prefs::kPromptForDownload, NULL));
+  EXPECT_FALSE(store_->GetValue(prefs::kPromptForDownload, NULL));
   policy.Set(key::kAllowFileSelectionDialogs, POLICY_LEVEL_MANDATORY,
              POLICY_SCOPE_USER, base::Value::CreateBooleanValue(true));
   provider_.UpdateChromePolicy(policy);
 
   // Allowing file-selection dialogs should not influence the PromptForDownload
   // pref.
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(prefs::kPromptForDownload, NULL));
+  EXPECT_FALSE(store_->GetValue(prefs::kPromptForDownload, NULL));
 }
 
 TEST_F(ConfigurationPolicyPrefStorePromptDownloadTest,
        DisableFileSelectionDialogs) {
   PolicyMap policy;
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(prefs::kPromptForDownload, NULL));
+  EXPECT_FALSE(store_->GetValue(prefs::kPromptForDownload, NULL));
   policy.Set(key::kAllowFileSelectionDialogs, POLICY_LEVEL_MANDATORY,
              POLICY_SCOPE_USER, base::Value::CreateBooleanValue(false));
   provider_.UpdateChromePolicy(policy);
 
   // Disabling file-selection dialogs should disable the PromptForDownload pref.
   const base::Value* value = NULL;
-  EXPECT_EQ(PrefStore::READ_OK, store_->GetValue(prefs::kPromptForDownload,
+  EXPECT_TRUE(store_->GetValue(prefs::kPromptForDownload,
                                                  &value));
   ASSERT_TRUE(value);
   bool prompt_for_download = true;
   bool result = value->GetAsBoolean(&prompt_for_download);
   ASSERT_TRUE(result);
   EXPECT_FALSE(prompt_for_download);
 }
 
 // Test cases for the Autofill policy setting.
 class ConfigurationPolicyPrefStoreAutofillTest
     : public ConfigurationPolicyPrefStoreTest {};
 
 TEST_F(ConfigurationPolicyPrefStoreAutofillTest, Default) {
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(prefs::kAutofillEnabled, NULL));
+  EXPECT_FALSE(store_->GetValue(prefs::kAutofillEnabled, NULL));
 }
 
 TEST_F(ConfigurationPolicyPrefStoreAutofillTest, Enabled) {
   PolicyMap policy;
   policy.Set(key::kAutoFillEnabled, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
              base::Value::CreateBooleanValue(true));
   provider_.UpdateChromePolicy(policy);
   // Enabling Autofill should not set the pref.
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(prefs::kAutofillEnabled, NULL));
+  EXPECT_FALSE(store_->GetValue(prefs::kAutofillEnabled, NULL));
 }
 
 TEST_F(ConfigurationPolicyPrefStoreAutofillTest, Disabled) {
   PolicyMap policy;
   policy.Set(key::kAutoFillEnabled, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
              base::Value::CreateBooleanValue(false));
   provider_.UpdateChromePolicy(policy);
   // Disabling Autofill should switch the pref to managed.
   const base::Value* value = NULL;
-  EXPECT_EQ(PrefStore::READ_OK,
-            store_->GetValue(prefs::kAutofillEnabled, &value));
+  EXPECT_TRUE(store_->GetValue(prefs::kAutofillEnabled, &value));
   ASSERT_TRUE(value);
   bool autofill_enabled = true;
   bool result = value->GetAsBoolean(&autofill_enabled);
   ASSERT_TRUE(result);
   EXPECT_FALSE(autofill_enabled);
 }
 
 // Exercises the policy refresh mechanism.
 class ConfigurationPolicyPrefStoreRefreshTest
     : public ConfigurationPolicyPrefStoreTest {
  protected:
   virtual void SetUp() {
     ConfigurationPolicyPrefStoreTest::SetUp();
     store_->AddObserver(&observer_);
   }
 
   virtual void TearDown() {
     store_->RemoveObserver(&observer_);
     ConfigurationPolicyPrefStoreTest::TearDown();
   }
 
   PrefStoreObserverMock observer_;
 };
 
 TEST_F(ConfigurationPolicyPrefStoreRefreshTest, Refresh) {
   const base::Value* value = NULL;
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(prefs::kHomePage, NULL));
+  EXPECT_FALSE(store_->GetValue(prefs::kHomePage, NULL));
 
   EXPECT_CALL(observer_, OnPrefValueChanged(prefs::kHomePage)).Times(1);
   PolicyMap policy;
   policy.Set(key::kHomepageLocation, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
              base::Value::CreateStringValue("http://www.chromium.org"));
   provider_.UpdateChromePolicy(policy);
   Mock::VerifyAndClearExpectations(&observer_);
-  EXPECT_EQ(PrefStore::READ_OK,
-            store_->GetValue(prefs::kHomePage, &value));
+  EXPECT_TRUE(store_->GetValue(prefs::kHomePage, &value));
   EXPECT_TRUE(base::StringValue("http://www.chromium.org").Equals(value));
 
   EXPECT_CALL(observer_, OnPrefValueChanged(_)).Times(0);
   provider_.UpdateChromePolicy(policy);
   Mock::VerifyAndClearExpectations(&observer_);
 
   EXPECT_CALL(observer_, OnPrefValueChanged(prefs::kHomePage)).Times(1);
   policy.Erase(key::kHomepageLocation);
   provider_.UpdateChromePolicy(policy);
   Mock::VerifyAndClearExpectations(&observer_);
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(prefs::kHomePage, NULL));
+  EXPECT_FALSE(store_->GetValue(prefs::kHomePage, NULL));
 }
 
 TEST_F(ConfigurationPolicyPrefStoreRefreshTest, Initialization) {
   EXPECT_FALSE(store_->IsInitializationComplete());
   EXPECT_CALL(provider_, IsInitializationComplete())
       .WillRepeatedly(Return(true));
   EXPECT_CALL(observer_, OnInitializationCompleted(true)).Times(1);
   PolicyMap policy;
   provider_.UpdateChromePolicy(policy);
   Mock::VerifyAndClearExpectations(&observer_);
   EXPECT_TRUE(store_->IsInitializationComplete());
 }
 
 // Tests for policies that don't quite fit the previous patterns.
 class ConfigurationPolicyPrefStoreOthersTest
     : public ConfigurationPolicyPrefStoreTest {};
 
 TEST_F(ConfigurationPolicyPrefStoreOthersTest, JavascriptEnabled) {
   // This is a boolean policy, but affects an integer preference.
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(prefs::kManagedDefaultJavaScriptSetting, NULL));
+  EXPECT_FALSE(store_->GetValue(prefs::kManagedDefaultJavaScriptSetting, NULL));
   PolicyMap policy;
   policy.Set(key::kJavascriptEnabled, POLICY_LEVEL_MANDATORY,
              POLICY_SCOPE_USER, base::Value::CreateBooleanValue(true));
   provider_.UpdateChromePolicy(policy);
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(prefs::kManagedDefaultJavaScriptSetting, NULL));
+  EXPECT_FALSE(store_->GetValue(prefs::kManagedDefaultJavaScriptSetting, NULL));
   policy.Set(key::kJavascriptEnabled, POLICY_LEVEL_MANDATORY,
              POLICY_SCOPE_USER, base::Value::CreateBooleanValue(false));
   provider_.UpdateChromePolicy(policy);
   const base::Value* value = NULL;
-  EXPECT_EQ(PrefStore::READ_OK,
-            store_->GetValue(prefs::kManagedDefaultJavaScriptSetting, &value));
+  EXPECT_TRUE(store_->GetValue(prefs::kManagedDefaultJavaScriptSetting,
+                               &value));
   EXPECT_TRUE(base::FundamentalValue(CONTENT_SETTING_BLOCK).Equals(value));
 }
 
 TEST_F(ConfigurationPolicyPrefStoreOthersTest, JavascriptEnabledOverridden) {
-  EXPECT_EQ(PrefStore::READ_NO_VALUE,
-            store_->GetValue(prefs::kManagedDefaultJavaScriptSetting, NULL));
+  EXPECT_FALSE(store_->GetValue(prefs::kManagedDefaultJavaScriptSetting, NULL));
   PolicyMap policy;
   policy.Set(key::kJavascriptEnabled, POLICY_LEVEL_MANDATORY,
              POLICY_SCOPE_USER, base::Value::CreateBooleanValue(false));
   provider_.UpdateChromePolicy(policy);
   const base::Value* value = NULL;
-  EXPECT_EQ(PrefStore::READ_OK,
-            store_->GetValue(prefs::kManagedDefaultJavaScriptSetting, &value));
+  EXPECT_TRUE(store_->GetValue(prefs::kManagedDefaultJavaScriptSetting,
+                               &value));
   EXPECT_TRUE(base::FundamentalValue(CONTENT_SETTING_BLOCK).Equals(value));
   // DefaultJavaScriptSetting overrides JavascriptEnabled.
   policy.Set(key::kDefaultJavaScriptSetting, POLICY_LEVEL_MANDATORY,
              POLICY_SCOPE_USER,
              base::Value::CreateIntegerValue(CONTENT_SETTING_ALLOW));
   provider_.UpdateChromePolicy(policy);
-  EXPECT_EQ(PrefStore::READ_OK,
-            store_->GetValue(prefs::kManagedDefaultJavaScriptSetting, &value));
+  EXPECT_TRUE(store_->GetValue(prefs::kManagedDefaultJavaScriptSetting,
+                               &value));
   EXPECT_TRUE(base::FundamentalValue(CONTENT_SETTING_ALLOW).Equals(value));
 }
 
 }  // namespace policy