Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: base/prefs/testing_pref_store.h

Issue 11365112: Change PrefStore::ReadResult to a boolean. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_PREFS_TESTING_PREF_STORE_H_ 5 #ifndef BASE_PREFS_TESTING_PREF_STORE_H_
6 #define BASE_PREFS_TESTING_PREF_STORE_H_ 6 #define BASE_PREFS_TESTING_PREF_STORE_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
11 #include "base/compiler_specific.h" 11 #include "base/compiler_specific.h"
12 #include "base/observer_list.h" 12 #include "base/observer_list.h"
13 #include "base/prefs/persistent_pref_store.h" 13 #include "base/prefs/persistent_pref_store.h"
14 #include "base/prefs/pref_value_map.h" 14 #include "base/prefs/pref_value_map.h"
15 15
16 // |TestingPrefStore| is a preference store implementation that allows tests to 16 // |TestingPrefStore| is a preference store implementation that allows tests to
17 // explicitly manipulate the contents of the store, triggering notifications 17 // explicitly manipulate the contents of the store, triggering notifications
18 // where appropriate. 18 // where appropriate.
19 class TestingPrefStore : public PersistentPrefStore { 19 class TestingPrefStore : public PersistentPrefStore {
20 public: 20 public:
21 TestingPrefStore(); 21 TestingPrefStore();
22 22
23 // Overriden from PrefStore. 23 // Overriden from PrefStore.
24 virtual ReadResult GetValue(const std::string& key, 24 virtual bool GetValue(const std::string& key,
25 const base::Value** result) const OVERRIDE; 25 const base::Value** result) const OVERRIDE;
26 virtual void AddObserver(PrefStore::Observer* observer) OVERRIDE; 26 virtual void AddObserver(PrefStore::Observer* observer) OVERRIDE;
27 virtual void RemoveObserver(PrefStore::Observer* observer) OVERRIDE; 27 virtual void RemoveObserver(PrefStore::Observer* observer) OVERRIDE;
28 virtual size_t NumberOfObservers() const OVERRIDE; 28 virtual size_t NumberOfObservers() const OVERRIDE;
29 virtual bool IsInitializationComplete() const OVERRIDE; 29 virtual bool IsInitializationComplete() const OVERRIDE;
30 30
31 // PersistentPrefStore overrides: 31 // PersistentPrefStore overrides:
32 virtual ReadResult GetMutableValue(const std::string& key, 32 virtual bool GetMutableValue(const std::string& key,
33 base::Value** result) OVERRIDE; 33 base::Value** result) OVERRIDE;
34 virtual void ReportValueChanged(const std::string& key) OVERRIDE; 34 virtual void ReportValueChanged(const std::string& key) OVERRIDE;
35 virtual void SetValue(const std::string& key, base::Value* value) OVERRIDE; 35 virtual void SetValue(const std::string& key, base::Value* value) OVERRIDE;
36 virtual void SetValueSilently(const std::string& key, 36 virtual void SetValueSilently(const std::string& key,
37 base::Value* value) OVERRIDE; 37 base::Value* value) OVERRIDE;
38 virtual void RemoveValue(const std::string& key) OVERRIDE; 38 virtual void RemoveValue(const std::string& key) OVERRIDE;
39 virtual void MarkNeedsEmptyValue(const std::string& key) OVERRIDE; 39 virtual void MarkNeedsEmptyValue(const std::string& key) OVERRIDE;
40 virtual bool ReadOnly() const OVERRIDE; 40 virtual bool ReadOnly() const OVERRIDE;
41 virtual PrefReadError GetReadError() const OVERRIDE; 41 virtual PrefReadError GetReadError() const OVERRIDE;
42 virtual PersistentPrefStore::PrefReadError ReadPrefs() OVERRIDE; 42 virtual PersistentPrefStore::PrefReadError ReadPrefs() OVERRIDE;
43 virtual void ReadPrefsAsync(ReadErrorDelegate* error_delegate) OVERRIDE; 43 virtual void ReadPrefsAsync(ReadErrorDelegate* error_delegate) OVERRIDE;
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 75
76 // Whether initialization has been completed. 76 // Whether initialization has been completed.
77 bool init_complete_; 77 bool init_complete_;
78 78
79 ObserverList<PrefStore::Observer, true> observers_; 79 ObserverList<PrefStore::Observer, true> observers_;
80 80
81 DISALLOW_COPY_AND_ASSIGN(TestingPrefStore); 81 DISALLOW_COPY_AND_ASSIGN(TestingPrefStore);
82 }; 82 };
83 83
84 #endif // BASE_PREFS_TESTING_PREF_STORE_H_ 84 #endif // BASE_PREFS_TESTING_PREF_STORE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698