src/runtime.cc - Issue 11365111: Object.observe: generate change records for indexed properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 11365111: Object.observe: generate change records for indexed properties. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressing comments; simplifications. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index 563333f0b3556d9e728ce445b02875f2ebd53d3c..f95c12983e84ac452f2c0393e4ef7bd757e3bc88 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -1073,7 +1073,7 @@ static MaybeObject* GetOwnProperty(Isolate* isolate,

// This could be an element.

uint32_t index;

if (name->AsArrayIndex(&index)) {

- switch (obj->HasLocalElement(index)) {

+ switch (obj->GetLocalElementType(index)) {

case JSObject::UNDEFINED_ELEMENT:

return heap->undefined_value();

@@ -4681,7 +4681,7 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_IsPropertyEnumerable) {

uint32_t index;

if (key->AsArrayIndex(&index)) {

- JSObject::LocalElementType type = object->HasLocalElement(index);

+ JSObject::LocalElementType type = object->GetLocalElementType(index);

switch (type) {

case JSObject::UNDEFINED_ELEMENT:

case JSObject::STRING_CHARACTER_ELEMENT:

« no previous file with comments | « src/objects-inl.h ('k') | test/mjsunit/harmony/object-observe.js » ('j') | no next file with comments »