Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11365095: Revert 166003 - Move Chromoting strings to string_resources.grd and simplify remoting_resources tar… (Closed)

Created:
8 years, 1 month ago by Sergey Ulanov
Modified:
8 years, 1 month ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, pam+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Revert 166003 - Move Chromoting strings to string_resources.grd and simplify remoting_resources target. Previously all strings were in messages.json files. Moving them to GRD file will allow to share them with native components. Also simplified how resources are generated: 1. Now <if> is used to handle branded strings instead of generating grd file in build time 2. Removed resource_ids - ids are now specified in grd files. BUG=158995 Review URL: https://codereview.chromium.org/11275101 TBR=sergeyu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=166013

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -5599 lines) Patch
M build/grit_action.gypi View 1 chunk +3 lines, -6 lines 0 comments Download
M remoting/base/resources_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/grit_action.gypi View 0 chunks +-1 lines, --1 lines 0 comments Download
M remoting/remoting.gyp View 7 chunks +89 lines, -94 lines 0 comments Download
M remoting/resources/common_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/resources/resource_ids View 0 chunks +-1 lines, --1 lines 0 comments Download
M remoting/resources/string_resources.grd View 1 chunk +9 lines, -516 lines 0 comments Download
D remoting/resources/string_resources_ar.xtb View 1 chunk +0 lines, -115 lines 0 comments Download
D remoting/resources/string_resources_bg.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_ca.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_cs.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_da.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_de.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_el.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_en-GB.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_en_US.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_es.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_es-419.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_et.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_fi.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_fil.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_fr.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_he.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_hi.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_hr.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_hu.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_id.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_it.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_ja.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_ko.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_lt.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_lv.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_nb.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_nl.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_pl.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_pt-BR.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_pt-PT.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_ro.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_ru.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_sk.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_sl.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_sr.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_sv.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_th.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_tr.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_uk.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_vi.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_zh-CN.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/resources/string_resources_zh-TW.xtb View 1 chunk +0 lines, -114 lines 0 comments Download
D remoting/tools/json_to_grd.py View 1 chunk +0 lines, -190 lines 0 comments Download
A + remoting/tools/remove_official_branding.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M remoting/webapp/build-webapp.py View 1 chunk +10 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Sergey Ulanov
8 years, 1 month ago (2012-11-05 20:17:44 UTC) #1 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698