Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 11365084: Some improvements in register usage in lithium compilation of LoadKeyed/StoreKeyed operations. (Closed)

Created:
8 years, 1 month ago by mvstanton
Modified:
8 years, 1 month ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Some improvements in register usage in lithium compilation of LoadKeyed/StoreKeyed operations. BUG= Committed: https://code.google.com/p/v8/source/detail?r=12912

Patch Set 1 #

Patch Set 2 : An additional optimization for arm, and cleanup. #

Patch Set 3 : Fixed a compilation error in ia32 hydrogen->lithium. #

Total comments: 8

Patch Set 4 : Response to comments, thx! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -192 lines) Patch
M src/arm/lithium-arm.cc View 1 2 3 3 chunks +15 lines, -25 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 3 2 chunks +6 lines, -12 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 2 3 1 chunk +7 lines, -4 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 2 3 4 chunks +29 lines, -40 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 3 6 chunks +18 lines, -83 lines 0 comments Download
M src/x64/lithium-x64.h View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 2 3 4 chunks +13 lines, -28 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mvstanton
Hi Danno, here are the changes we discussed Friday. I've found an additional optimization in ...
8 years, 1 month ago (2012-11-05 14:42:37 UTC) #1
danno
LGTM with comments http://codereview.chromium.org/11365084/diff/9001/src/arm/lithium-arm.cc File src/arm/lithium-arm.cc (right): http://codereview.chromium.org/11365084/diff/9001/src/arm/lithium-arm.cc#newcode1884 src/arm/lithium-arm.cc:1884: external_pointer = UseRegisterAtStart(instr->elements()); I don't see ...
8 years, 1 month ago (2012-11-07 22:34:38 UTC) #2
mvstanton
thanks Danno for the good advice. I wasn't able to move the ArrayOpClobbersKey though, see ...
8 years, 1 month ago (2012-11-09 09:43:13 UTC) #3
danno
8 years, 1 month ago (2012-11-09 10:06:43 UTC) #4
Still LGTM

Powered by Google App Engine
This is Rietveld 408576698