Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1136503003: Consolidate ui/events/keycodes/dom[34]/ into .../dom/ (Closed)

Created:
5 years, 7 months ago by kpschoedel
Modified:
5 years, 7 months ago
Reviewers:
Wez
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, chromoting-reviews_chromium.org, shuchen+watch_chromium.org, sievers+watch_chromium.org, dmazzoni+watch_chromium.org, aandrey+blink_chromium.org, stevenjb+watch_chromium.org, extensions-reviews_chromium.org, aboxhall+watch_chromium.org, jdduke+watch_chromium.org, jam, jbauman+watch_chromium.org, nona+watch_chromium.org, je_julie, darin-cc_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, ozone-reviews_chromium.org, mlamouri+watch-content_chromium.org, tdresser+watch_chromium.org, penghuang+watch_chromium.org, yuzo+watch_chromium.org, oshima+watch_chromium.org, kalyank, piman+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org, plundblad+watch_chromium.org, tfarina, nektar+watch_chromium.org, yurys, davemoore+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, danakj+watch_chromium.org, James Su, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ui/events/keycodes/dom[34]/ into .../dom/ The names dom3 and dom4 reflect obsolete documentation and no longer denote anything useful. R=wez TBR=jam Committed: https://crrev.com/3b0960abbbec966773b933a686677485aaf1a4e4 Cr-Commit-Position: refs/heads/master@{#329176}

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebase #

Patch Set 3 : rename to .inc #

Patch Set 4 : re²base #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -1571 lines) Patch
M ash/wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard_ozone.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/events/event_rewriter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/events/event_rewriter_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/braille_display_private/brlapi_keycode_map.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/remoting/key_code_map.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/remoting/key_code_test_map.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/protocol/input_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/web_input_event_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/web_input_event_aura_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/child/blink_platform_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/content_renderer.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/browser_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/usb_key_code_conversion_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/usb_key_code_conversion_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/usb_key_code_conversion_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/event_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/plugin/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/plugin/pepper_input_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/input_injector_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/input_injector_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/input_injector_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/input_injector_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/input_event_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/remoting_client.gypi View 1 chunk +1 line, -1 line 0 comments Download
M remoting/remoting_host.gypi View 1 chunk +1 line, -1 line 0 comments Download
M remoting/remoting_nacl.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/input_method_chromeos_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/BUILD.gn View 1 2 3 5 chunks +11 lines, -11 lines 0 comments Download
M ui/events/event.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/event.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M ui/events/event_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/events.gyp View 1 2 3 5 chunks +12 lines, -12 lines 0 comments Download
M ui/events/events_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
A ui/events/keycodes/dom/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A + ui/events/keycodes/dom/dom_code.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + ui/events/keycodes/dom/dom_key.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + ui/events/keycodes/dom/dom_key_data.inc View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/events/keycodes/dom/keycode_converter.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/events/keycodes/dom/keycode_converter.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
A + ui/events/keycodes/dom/keycode_converter_data.inc View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/events/keycodes/dom/keycode_converter_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
D ui/events/keycodes/dom3/dom_code.h View 1 chunk +0 lines, -18 lines 0 comments Download
D ui/events/keycodes/dom3/dom_key.h View 1 chunk +0 lines, -18 lines 0 comments Download
D ui/events/keycodes/dom3/dom_key_data.h View 1 chunk +0 lines, -376 lines 0 comments Download
D ui/events/keycodes/dom4/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D ui/events/keycodes/dom4/keycode_converter.h View 1 chunk +0 lines, -112 lines 0 comments Download
D ui/events/keycodes/dom4/keycode_converter.cc View 1 chunk +0 lines, -282 lines 0 comments Download
D ui/events/keycodes/dom4/keycode_converter_data.h View 1 chunk +0 lines, -481 lines 0 comments Download
D ui/events/keycodes/dom4/keycode_converter_unittest.cc View 1 chunk +0 lines, -155 lines 0 comments Download
M ui/events/keycodes/keyboard_code_conversion.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/keycodes/keyboard_code_conversion_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/keycodes/keyboard_code_conversion_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/events/keycodes/keyboard_code_conversion_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/keycodes/keyboard_code_conversion_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/keycodes/keyboard_code_conversion_x.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/events/keycodes/keyboard_code_conversion_xkb.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/evdev/input_injector_evdev.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/evdev/keyboard_evdev.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/evdev/keyboard_util_evdev.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/events_ozone.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/events/ozone/layout/layout_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/layout/stub/stub_keyboard_layout_engine.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/ozone/layout/xkb/xkb_evdev_codes.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/win/events_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/keyboard.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/keyboard_util.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ui/ozone/demo/ozone_demo.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/public/system_input_injector.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/cocoa/bridged_content_view.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 26 (14 generated)
kpschoedel
As suggested.
5 years, 7 months ago (2015-05-07 18:06:29 UTC) #2
Wez
LGTM w/ a naming nit, while we're moving stuff around. ;) https://codereview.chromium.org/1136503003/diff/1/ui/events/keycodes/dom/dom_key_data.h File ui/events/keycodes/dom/dom_key_data.h (right): ...
5 years, 7 months ago (2015-05-08 01:15:59 UTC) #3
kpschoedel
https://codereview.chromium.org/1136503003/diff/1/ui/events/keycodes/dom/dom_key_data.h File ui/events/keycodes/dom/dom_key_data.h (right): https://codereview.chromium.org/1136503003/diff/1/ui/events/keycodes/dom/dom_key_data.h#newcode1 ui/events/keycodes/dom/dom_key_data.h:1: // Copyright 2014 The Chromium Authors. All rights reserved. ...
5 years, 7 months ago (2015-05-08 17:38:25 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136503003/60001
5 years, 7 months ago (2015-05-08 17:40:31 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/50999) ios_dbg_simulator_ninja on ...
5 years, 7 months ago (2015-05-08 17:51:59 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136503003/80001
5 years, 7 months ago (2015-05-08 18:04:01 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/70000)
5 years, 7 months ago (2015-05-08 18:22:51 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136503003/100001
5 years, 7 months ago (2015-05-08 19:32:19 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/5462)
5 years, 7 months ago (2015-05-09 00:57:01 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136503003/120001
5 years, 7 months ago (2015-05-11 16:37:38 UTC) #24
commit-bot: I haz the power
Committed patchset #5 (id:120001)
5 years, 7 months ago (2015-05-11 17:52:23 UTC) #25
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 17:53:34 UTC) #26
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/3b0960abbbec966773b933a686677485aaf1a4e4
Cr-Commit-Position: refs/heads/master@{#329176}

Powered by Google App Engine
This is Rietveld 408576698