Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: chromeos/network/network_sms_handler_unittest.cc

Issue 11365022: Add TestInterface methods for adding shill stub devices and services (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Yet another clang fix Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/network_sms_handler_unittest.cc
diff --git a/chromeos/network/network_sms_handler_unittest.cc b/chromeos/network/network_sms_handler_unittest.cc
index a201864f7fc487c9020e948b2eb509dcccc5449f..a821ce8f393c09395a0b0513261979f1560bd71e 100644
--- a/chromeos/network/network_sms_handler_unittest.cc
+++ b/chromeos/network/network_sms_handler_unittest.cc
@@ -12,7 +12,10 @@
#include "base/message_loop.h"
#include "chromeos/chromeos_switches.h"
#include "chromeos/dbus/dbus_thread_manager.h"
+#include "chromeos/dbus/shill_device_client.h"
+#include "chromeos/dbus/shill_manager_client.h"
#include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/cros_system_api/dbus/service_constants.h"
namespace chromeos {
@@ -54,6 +57,15 @@ class NetworkSmsHandlerTest : public testing::Test {
virtual void SetUp() OVERRIDE {
// Initialize DBusThreadManager with a stub implementation.
DBusThreadManager::InitializeWithStub();
+ ShillManagerClient::TestInterface* manager_test =
+ DBusThreadManager::Get()->GetShillManagerClient()->GetTestInterface();
+ ASSERT_TRUE(manager_test);
+ manager_test->AddDevice("stub_cellular_device2");
+ ShillDeviceClient::TestInterface* device_test =
+ DBusThreadManager::Get()->GetShillDeviceClient()->GetTestInterface();
+ ASSERT_TRUE(device_test);
+ device_test->AddDevice("stub_cellular_device2", flimflam::kTypeCellular,
+ "/org/freedesktop/ModemManager1/stub/0", ":stub.0");
}
virtual void TearDown() OVERRIDE {
@@ -85,6 +97,7 @@ TEST_F(NetworkSmsHandlerTest, SmsHandlerDbusStub) {
const std::set<std::string>& messages(test_observer->messages());
// Note: The following string corresponds to values in
// ModemMessagingClientStubImpl and SmsClientStubImpl.
+ // TODO(stevenjb): Use a TestInterface to set this up to remove dependency.
const char kMessage1[] = "SMSClientStubImpl: Test Message: /SMS/0";
EXPECT_EQ(messages.find(kMessage1), messages.end());
« chromeos/dbus/shill_manager_client.cc ('K') | « chromeos/network/network_sms_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698